From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Ananth N Mavinakayanahalli <ananth@linux.ibm.com>
Cc: ravi.bangoria@linux.ibm.com, paulus@samba.org,
sandipan@linux.ibm.com, naveen.n.rao@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] lib/sstep: Fix incorrect return from analyze_instr()
Date: Fri, 22 Jan 2021 11:57:25 +0530 [thread overview]
Message-ID: <20210122062725.GD9569@DESKTOP-TDPLP67.localdomain> (raw)
In-Reply-To: <161124771457.333703.14641179082577500423.stgit@thinktux.local>
On 2021/01/21 10:18PM, Ananth N Mavinakayanahalli wrote:
> We currently just percolate the return value from analyze_instr()
> to the caller of emulate_step(), especially if it is a -1.
>
> For one particular case (opcode = 4) for instructions that
> aren't currently emulated, we are returning 'should not be
> single-stepped' while we should have returned 0 which says
> 'did not emulate, may have to single-step'.
>
> Signed-off-by: Ananth N Mavinakayanahalli <ananth@linux.ibm.com>
> Tested-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
> arch/powerpc/lib/sstep.c | 49 +++++++++++++++++++++++++---------------------
> 1 file changed, 27 insertions(+), 22 deletions(-)
Fixes: 930d6288a26787 ("powerpc: sstep: Add support for maddhd, maddhdu, maddld instructions")
Reviewed-by: Naveen N. Rao < naveen.n.rao@linux.vnet.ibm.com>
- Naveen
next prev parent reply other threads:[~2021-01-22 6:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 16:48 [PATCH] lib/sstep: Fix incorrect return from analyze_instr() Ananth N Mavinakayanahalli
2021-01-22 6:27 ` Naveen N. Rao [this message]
2021-01-22 7:09 ` Sandipan Das
2021-01-23 0:33 ` Michael Ellerman
2021-01-25 4:52 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122062725.GD9569@DESKTOP-TDPLP67.localdomain \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=ananth@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=paulus@samba.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=sandipan@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox