* [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range
[not found] <20210126045404.2492588-1-npiggin@gmail.com>
@ 2021-01-26 4:54 ` Nicholas Piggin
2021-01-26 6:38 ` Christoph Hellwig
2021-01-26 7:25 ` Cédric Le Goater
0 siblings, 2 replies; 3+ messages in thread
From: Nicholas Piggin @ 2021-01-26 4:54 UTC (permalink / raw)
To: linux-mm, Andrew Morton
Cc: Cédric Le Goater, linuxppc-dev, linux-kernel,
Nicholas Piggin, Christoph Hellwig
iounmap will remove ptes.
Cc: "Cédric Le Goater" <clg@kaod.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/sysdev/xive/common.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
index 595310e056f4..d6c2069cc828 100644
--- a/arch/powerpc/sysdev/xive/common.c
+++ b/arch/powerpc/sysdev/xive/common.c
@@ -959,16 +959,12 @@ EXPORT_SYMBOL_GPL(is_xive_irq);
void xive_cleanup_irq_data(struct xive_irq_data *xd)
{
if (xd->eoi_mmio) {
- unmap_kernel_range((unsigned long)xd->eoi_mmio,
- 1u << xd->esb_shift);
iounmap(xd->eoi_mmio);
if (xd->eoi_mmio == xd->trig_mmio)
xd->trig_mmio = NULL;
xd->eoi_mmio = NULL;
}
if (xd->trig_mmio) {
- unmap_kernel_range((unsigned long)xd->trig_mmio,
- 1u << xd->esb_shift);
iounmap(xd->trig_mmio);
xd->trig_mmio = NULL;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range
2021-01-26 4:54 ` [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range Nicholas Piggin
@ 2021-01-26 6:38 ` Christoph Hellwig
2021-01-26 7:25 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-01-26 6:38 UTC (permalink / raw)
To: Nicholas Piggin
Cc: linux-kernel, linux-mm, Cédric Le Goater, Andrew Morton,
linuxppc-dev, Christoph Hellwig
On Tue, Jan 26, 2021 at 02:54:02PM +1000, Nicholas Piggin wrote:
> iounmap will remove ptes.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range
2021-01-26 4:54 ` [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range Nicholas Piggin
2021-01-26 6:38 ` Christoph Hellwig
@ 2021-01-26 7:25 ` Cédric Le Goater
1 sibling, 0 replies; 3+ messages in thread
From: Cédric Le Goater @ 2021-01-26 7:25 UTC (permalink / raw)
To: Nicholas Piggin, linux-mm, Andrew Morton
Cc: linuxppc-dev, linux-kernel, Christoph Hellwig
On 1/26/21 5:54 AM, Nicholas Piggin wrote:
> iounmap will remove ptes.
>
> Cc: "Cédric Le Goater" <clg@kaod.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Looks good.
Acked-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> arch/powerpc/sysdev/xive/common.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
> index 595310e056f4..d6c2069cc828 100644
> --- a/arch/powerpc/sysdev/xive/common.c
> +++ b/arch/powerpc/sysdev/xive/common.c
> @@ -959,16 +959,12 @@ EXPORT_SYMBOL_GPL(is_xive_irq);
> void xive_cleanup_irq_data(struct xive_irq_data *xd)
> {
> if (xd->eoi_mmio) {
> - unmap_kernel_range((unsigned long)xd->eoi_mmio,
> - 1u << xd->esb_shift);
> iounmap(xd->eoi_mmio);
> if (xd->eoi_mmio == xd->trig_mmio)
> xd->trig_mmio = NULL;
> xd->eoi_mmio = NULL;
> }
> if (xd->trig_mmio) {
> - unmap_kernel_range((unsigned long)xd->trig_mmio,
> - 1u << xd->esb_shift);
> iounmap(xd->trig_mmio);
> xd->trig_mmio = NULL;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-26 11:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210126045404.2492588-1-npiggin@gmail.com>
2021-01-26 4:54 ` [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range Nicholas Piggin
2021-01-26 6:38 ` Christoph Hellwig
2021-01-26 7:25 ` Cédric Le Goater
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).