From: Rob Herring <robh@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
timur@kernel.org, lgirdwood@gmail.com,
linuxppc-dev@lists.ozlabs.org, Xiubo.Lee@gmail.com,
linux-kernel@vger.kernel.org, tiwai@suse.com,
nicoleotsuka@gmail.com, broonie@kernel.org, perex@perex.cz,
festevam@gmail.com
Subject: Re: [PATCH v2 7/7] ASoC: dt-bindings: imx-rpmsg: Add binding doc for rpmsg machine driver
Date: Wed, 10 Feb 2021 16:17:04 -0600 [thread overview]
Message-ID: <20210210221704.GA2894134@robh.at.kernel.org> (raw)
In-Reply-To: <1612693435-31418-8-git-send-email-shengjiu.wang@nxp.com>
On Sun, Feb 07, 2021 at 06:23:55PM +0800, Shengjiu Wang wrote:
> Imx-rpmsg is a new added machine driver for supporting audio on Cortex-M
> core. The Cortex-M core will control the audio interface, DMA and audio
> codec, setup the pipeline, the audio driver on Cortex-A core side is just
> to communitcate with M core, it is a virtual sound card and don't touch
> the hardware.
I don't understand why there are 2 nodes for this other than you happen
to want to split this into 2 Linux drivers. It's 1 h/w thing.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
> .../bindings/sound/imx-audio-rpmsg.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-rpmsg.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/imx-audio-rpmsg.yaml b/Documentation/devicetree/bindings/sound/imx-audio-rpmsg.yaml
> new file mode 100644
> index 000000000000..b941aeb80678
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/imx-audio-rpmsg.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/imx-audio-rpmsg.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX audio complex with rpmsg
> +
> +maintainers:
> + - Shengjiu Wang <shengjiu.wang@nxp.com>
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,imx-audio-rpmsg
> +
> + model:
> + $ref: /schemas/types.yaml#/definitions/string
> + description: User specified audio sound card name
> +
> + audio-cpu:
> + description: The phandle of an CPU DAI controller
> +
> + rpmsg-out:
> + description: |
> + This is a boolean property. If present, the transmitting function
> + will be enabled,
> +
> + rpmsg-in:
> + description: |
> + This is a boolean property. If present, the receiving function
> + will be enabled.
> +
> +required:
> + - compatible
> + - model
> + - audio-cpu
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + sound-rpmsg {
> + compatible = "fsl,imx-audio-rpmsg";
> + model = "ak4497-audio";
> + audio-cpu = <&rpmsg_audio>;
> + rpmsg-out;
> + };
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-02-10 22:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 10:23 [PATCH v2 0/7] Add audio driver base on rpmsg on i.MX platform Shengjiu Wang
2021-02-07 10:23 ` [PATCH v2 1/7] ASoC: soc-component: Add snd_soc_pcm_component_ack Shengjiu Wang
2021-02-07 10:23 ` [PATCH v2 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg Shengjiu Wang
2021-02-08 11:51 ` Mark Brown
2021-02-09 9:16 ` Shengjiu Wang
2021-02-09 22:29 ` Mark Brown
2021-02-10 6:35 ` Shengjiu Wang
2021-02-10 15:38 ` Mark Brown
2021-02-18 7:57 ` Shengjiu Wang
2021-02-22 13:46 ` Mark Brown
2021-02-07 10:23 ` [PATCH v2 3/7] ASoC: dt-bindings: fsl_rpmsg: Add binding doc for rpmsg cpu dai driver Shengjiu Wang
2021-02-10 22:12 ` Rob Herring
2021-02-18 7:21 ` Shengjiu Wang
2021-02-25 3:10 ` Fabio Estevam
2021-02-07 10:23 ` [PATCH v2 4/7] ASoC: imx-audio-rpmsg: Add rpmsg_driver for audio channel Shengjiu Wang
2021-02-07 10:23 ` [PATCH v2 5/7] ASoC: imx-pcm-rpmsg: Add platform driver for audio base on rpmsg Shengjiu Wang
2021-02-07 10:23 ` [PATCH v2 6/7] ASoC: imx-rpmsg: Add machine " Shengjiu Wang
2021-02-07 10:23 ` [PATCH v2 7/7] ASoC: dt-bindings: imx-rpmsg: Add binding doc for rpmsg machine driver Shengjiu Wang
2021-02-10 22:17 ` Rob Herring [this message]
2021-02-18 7:23 ` Shengjiu Wang
2021-03-04 20:04 ` Rob Herring
2021-03-05 2:55 ` Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210221704.GA2894134@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).