From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BED3C433E0 for ; Mon, 1 Mar 2021 07:54:20 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26B5664E38 for ; Mon, 1 Mar 2021 07:54:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26B5664E38 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4DpswT42cwz3dMH for ; Mon, 1 Mar 2021 18:54:17 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Dpsw62YGdz30LR for ; Mon, 1 Mar 2021 18:53:57 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id 1CE7E68BEB; Mon, 1 Mar 2021 08:53:53 +0100 (CET) Date: Mon, 1 Mar 2021 08:53:52 +0100 From: Christoph Hellwig To: Anshuman Khandual Subject: Re: [PATCH] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE Message-ID: <20210301075352.GA27659@lst.de> References: <1614577853-7452-1-git-send-email-anshuman.khandual@arm.com> <20210301062358.GA25761@lst.de> <89f2d77c-f4bc-8f7b-a6b0-1c04e422fb77@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89f2d77c-f4bc-8f7b-a6b0-1c04e422fb77@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Mackerras , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Christoph Hellwig Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 01, 2021 at 01:13:41PM +0530, Anshuman Khandual wrote: > > doesn't this need a 'if HUGETLB_PAGE' > > While making HUGETLB_PAGE_SIZE_VARIABLE a generic option, also made it > dependent on HUGETLB_PAGE. Should not that gate HUGETLB_PAGE_SIZE_VARIABLE > when HUGETLB_PAGE is not available irrespective of the select statement on > the platforms ? depends doesn't properly work for variables that are selected.