* [PATCH] powerpc/eeh: Fix build failure with CONFIG_PROC_FS=n
@ 2021-03-14 9:33 Michael Ellerman
2021-03-31 1:09 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2021-03-14 9:33 UTC (permalink / raw)
To: linuxppc-dev
The build fails with CONFIG_PROC_FS=n:
arch/powerpc/kernel/eeh.c:1571:12: error: ‘proc_eeh_show’ defined but not used
1571 | static int proc_eeh_show(struct seq_file *m, void *v)
Wrap proc_eeh_show() in an ifdef to avoid it.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
arch/powerpc/kernel/eeh.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
index cd60bc1c8701..01dbb44a0fe3 100644
--- a/arch/powerpc/kernel/eeh.c
+++ b/arch/powerpc/kernel/eeh.c
@@ -1568,6 +1568,7 @@ int eeh_pe_inject_err(struct eeh_pe *pe, int type, int func,
}
EXPORT_SYMBOL_GPL(eeh_pe_inject_err);
+#ifdef CONFIG_PROC_FS
static int proc_eeh_show(struct seq_file *m, void *v)
{
if (!eeh_enabled()) {
@@ -1594,6 +1595,7 @@ static int proc_eeh_show(struct seq_file *m, void *v)
return 0;
}
+#endif /* CONFIG_PROC_FS */
#ifdef CONFIG_DEBUG_FS
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/eeh: Fix build failure with CONFIG_PROC_FS=n
2021-03-14 9:33 [PATCH] powerpc/eeh: Fix build failure with CONFIG_PROC_FS=n Michael Ellerman
@ 2021-03-31 1:09 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2021-03-31 1:09 UTC (permalink / raw)
To: Michael Ellerman, linuxppc-dev
On Sun, 14 Mar 2021 20:33:00 +1100, Michael Ellerman wrote:
> The build fails with CONFIG_PROC_FS=n:
>
> arch/powerpc/kernel/eeh.c:1571:12: error: ‘proc_eeh_show’ defined but not used
> 1571 | static int proc_eeh_show(struct seq_file *m, void *v)
>
> Wrap proc_eeh_show() in an ifdef to avoid it.
Applied to powerpc/next.
[1/1] powerpc/eeh: Fix build failure with CONFIG_PROC_FS=n
https://git.kernel.org/powerpc/c/7a7685acd2129e2e5d433636120b4c5038c03e51
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 1:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-14 9:33 [PATCH] powerpc/eeh: Fix build failure with CONFIG_PROC_FS=n Michael Ellerman
2021-03-31 1:09 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).