From: He Ying <heying24@huawei.com>
To: <mpe@ellerman.id.au>, <benh@kernel.crashing.org>,
<paulus@samba.org>, <npiggin@gmail.com>, <dja@axtens.net>,
<akpm@linux-foundation.org>, <rppt@kernel.org>,
<aneesh.kumar@linux.ibm.com>, <clg@kaod.org>
Cc: johnny.chenyi@huawei.com, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH] powerpc: Fix missing prototype problems for "arch/powerpc/kernel/setup_64.c"
Date: Mon, 15 Mar 2021 08:04:44 -0400 [thread overview]
Message-ID: <20210315120444.215905-1-heying24@huawei.com> (raw)
The variables 'uaccess_fulsh' and 'entry_flush' are not referenced
outside the file. So define them as static to avoid the warnings.
And add a prototype for the function 'panic_smp_self_stop' for the
same purpose.
Sparse also warns that 'rfi_flush' should be static. However, it's
referenced outside the file.
The warnings about the file reported by sparse are as follows:
arch/powerpc/kernel/setup_64.c:422:6: warning: symbol 'panic_smp_self_stop' was not declared. Should it be static?
arch/powerpc/kernel/setup_64.c:951:6: warning: symbol 'rfi_flush' was not declared. Should it be static?
arch/powerpc/kernel/setup_64.c:952:6: warning: symbol 'entry_flush' was not declared. Should it be static?
arch/powerpc/kernel/setup_64.c:953:6: warning: symbol 'uaccess_flush' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: He Ying <heying24@huawei.com>
---
arch/powerpc/kernel/setup_64.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index 560ed8b975e7..603aacd8527b 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -71,6 +71,8 @@
#include "setup.h"
+extern void panic_smp_self_stop(void);
+
int spinning_secondaries;
u64 ppc64_pft_size;
@@ -949,8 +951,8 @@ static bool no_rfi_flush;
static bool no_entry_flush;
static bool no_uaccess_flush;
bool rfi_flush;
-bool entry_flush;
-bool uaccess_flush;
+static bool entry_flush;
+static bool uaccess_flush;
DEFINE_STATIC_KEY_FALSE(uaccess_flush_key);
EXPORT_SYMBOL(uaccess_flush_key);
--
2.17.1
next reply other threads:[~2021-03-15 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 12:04 He Ying [this message]
2021-03-15 12:17 ` [PATCH] powerpc: Fix missing prototype problems for "arch/powerpc/kernel/setup_64.c" Christophe Leroy
2021-03-15 12:48 ` heying (H)
2021-03-15 12:57 ` Cédric Le Goater
2021-03-15 13:01 ` Christophe Leroy
2021-03-15 13:14 ` Cédric Le Goater
2021-03-16 2:04 ` heying (H)
2021-03-15 12:57 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315120444.215905-1-heying24@huawei.com \
--to=heying24@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=clg@kaod.org \
--cc=dja@axtens.net \
--cc=johnny.chenyi@huawei.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox