From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCE8C433E0 for ; Wed, 17 Mar 2021 17:58:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC5ED64F10 for ; Wed, 17 Mar 2021 17:58:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC5ED64F10 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F0yYn0xzKz3bwb for ; Thu, 18 Mar 2021 04:58:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F0yYQ5M16z2xYd for ; Thu, 18 Mar 2021 04:57:46 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id 6243568BFE; Wed, 17 Mar 2021 18:57:42 +0100 (CET) Date: Wed, 17 Mar 2021 18:57:42 +0100 From: Christoph Hellwig To: Konrad Rzeszutek Wilk Subject: Re: [PATCH 12/14] swiotlb: move global variables into a new io_tlb_mem structure Message-ID: <20210317175742.GA29280@lst.de> References: <20210301074436.919889-1-hch@lst.de> <20210301074436.919889-13-hch@lst.de> <20210317134204.GA315788@konrad-char-us-oracle-com.allregionaliads.osdevelopmeniad.oraclevcn.com> <20210317135327.GA10797@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dongli Zhang , iommu@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Claire Chang , linuxppc-dev@lists.ozlabs.org, Christoph Hellwig Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Mar 17, 2021 at 01:51:56PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Mar 17, 2021 at 02:53:27PM +0100, Christoph Hellwig wrote: > > On Wed, Mar 17, 2021 at 01:42:07PM +0000, Konrad Rzeszutek Wilk wrote: > > > > - alloc_size = PAGE_ALIGN(io_tlb_nslabs * sizeof(size_t)); > > > > - io_tlb_alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > > > - if (!io_tlb_alloc_size) > > > > - panic("%s: Failed to allocate %zu bytes align=0x%lx\n", > > > > - __func__, alloc_size, PAGE_SIZE); > > > > > > Shouldn't this be converted to: > > > mem->alloc_size = memblock_alloc(alloc_size, PAGE_SIZE); > > > if (...) > > > > > > Seems that it got lost in the search and replace? > > > > Yes, I messed that up during the rebase. That being said it magically > > gets fixed in the next patch.. > > Yes. However if someone does a bisection they are going to be mighty unhappy > with you. Sure, I was planning on fixing it anyway. Just waiting for feedback on the rest of the patches before doing a respin.