From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F924C433C1 for ; Mon, 22 Mar 2021 14:54:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B090261930 for ; Mon, 22 Mar 2021 14:54:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B090261930 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4F3yFd0Grrz30F2 for ; Tue, 23 Mar 2021 01:54:29 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4F3yFH2XjNz2yhm for ; Tue, 23 Mar 2021 01:54:10 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id A32F268BEB; Mon, 22 Mar 2021 15:54:03 +0100 (CET) Date: Mon, 22 Mar 2021 15:54:03 +0100 From: Christoph Hellwig To: Russell King - ARM Linux admin Subject: Re: [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig Message-ID: <20210322145403.GA30942@lst.de> References: <20210318045706.200458-1-hch@lst.de> <20210318045706.200458-3-hch@lst.de> <20210319170753.GV1463@shell.armlinux.org.uk> <20210319175311.GW1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210319175311.GW1463@shell.armlinux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Thomas Bogendoerfer , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Ivan Kokshaysky , linux-alpha@vger.kernel.org, Geert Uytterhoeven , Matt Turner , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org, Richard Henderson Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Mar 19, 2021 at 05:53:12PM +0000, Russell King - ARM Linux admin wrote: > If I extend the arch/arm/kernel/bios32.c code to kill BARs 2/3 (which > actually are not present on the CY82C693) then the IDE driver works > for me, but the PATA driver does not: > > cy82c693 0000:00:06.1: IDE controller (0x1080:0xc693 rev 0x00) > cy82c693 0000:00:06.1: not 100% native mode: will probe irqs later > legacy IDE will be removed in 2021, please switch to libata > Report any missing HW support to linux-ide@vger.kernel.org > ide0: BM-DMA at 0x1080-0x1087 > ide1: BM-DMA at 0x1088-0x108f > Probing IDE interface ide0... > hda: PIONEER DVD-RW DVR-105, ATAPI CD/DVD-ROM drive > hda: host max PIO4 wanted PIO255(auto-tune) selected PIO4 > ... > > (unbind Cypress_IDE and try binding pata_cypress) > > pata_cypress 0000:00:06.1: no available native port This comes from ata_pci_sff_init_host when it tails to initialize a port. There are three cases why it can't initialize the port: 1) because it is marked as dummy, which is the case for the second port of the cypress controller, but you're not using that even with the old ide driver, and we'd still not get that message just because of that second port. 2) when ata_resources_present returns false because the BAR has a zero start or length 3) because pcim_iomap_regions() fails. This prints a warning to the log ("failed to request/iomap BARs for port %d (errno=%d)") that you should have seen So the problem here has to be number two. The legacy ide driver OTOH seems to lack a lot of these checks, although I'm not sure how it manages to actually work without those. Can you show how the BAR assignment for the device looks using lscpi or a tool of your choice?