From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v7] powerpc/irq: Inline call_do_irq() and call_do_softirq()
Date: Thu, 25 Mar 2021 07:44:36 -0500 [thread overview]
Message-ID: <20210325124436.GG16691@gate.crashing.org> (raw)
In-Reply-To: <87k0pwhh5y.fsf@mpe.ellerman.id.au>
On Wed, Mar 24, 2021 at 11:26:01PM +1100, Michael Ellerman wrote:
> Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> > Hmm. It is the first time we use named parameters in powerpc assembly, isn't it ?
> Yeah I'd like us to use it more, I think it helps readability a lot.
..in some cases. Not in most cases :-(
> > Wondering, how would the below look like with named parameters (from __put_user_asm2_goto) ?
> >
> > stw%X1 %L0, %L1
>
> Not sure, possibly that's too complicated for it :)
asm("stw%X[name1] %L[name0],%L[name1]" :: [name0]"r"(x), [name1]"m"(p));
Yes, it is not more readable *at all*.
Segher
next prev parent reply other threads:[~2021-03-25 12:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 12:22 [PATCH v7] powerpc/irq: Inline call_do_irq() and call_do_softirq() Michael Ellerman
2021-03-22 15:25 ` Christophe Leroy
2021-03-24 12:26 ` Michael Ellerman
2021-03-25 12:44 ` Segher Boessenkool [this message]
2021-03-31 1:09 ` Michael Ellerman
2021-04-26 18:50 ` Nathan Chancellor
2021-04-27 6:39 ` Christophe Leroy
2021-04-27 20:42 ` Nick Desaulniers
2021-04-30 21:33 ` Nick Desaulniers
2021-05-04 19:56 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325124436.GG16691@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).