From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A2FC433B4 for ; Wed, 7 Apr 2021 15:30:28 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0D9461382 for ; Wed, 7 Apr 2021 15:30:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0D9461382 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FFpHk0ftdz3bwp for ; Thu, 8 Apr 2021 01:30:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.216.51; helo=mail-pj1-f51.google.com; envelope-from=mcgrof@gmail.com; receiver=) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FFpHK4GG9z2yxl for ; Thu, 8 Apr 2021 01:30:02 +1000 (AEST) Received: by mail-pj1-f51.google.com with SMTP id lr1-20020a17090b4b81b02900ea0a3f38c1so3228152pjb.0 for ; Wed, 07 Apr 2021 08:30:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+M5ErOA6vMHXgHMo812hqipKBEarvAzxNuznNu4dPh4=; b=e1+clxQB/g4f+0BtEQG1H1NAAShfOPoQDUOwOyftcwd8G+FLUiYkJKofkN5Wjiw4ZI bFd67VovgAVm5OX7xiGmrzzOMH6hUpQEhFLTs4HVB9H9eETsTBbGtcAuw4rSZhbmLkVG ucoT5w4m1ZQQT5xsANtM8/wsC0rwLofTxWHIHaZO/5vQEXUj5MEzXWOG9ZyBG9EWSU71 eGLmI6EcvMdLkpSslUoM0HUsXITrGOSg4i9ced3NX3FXXlBPLACabJjeGwDBm0b+vDjk S7uM9JT+FqIHgTk7kioO5PAH8am6blJozuonNMVBiZ6EwGwoWM7NwVU3K+qG3/uO74kC //Yw== X-Gm-Message-State: AOAM530xxOpLaGFbxiboorMOQP1BvkgWblcaUxlZ+ZG2SsqEbO06q6Vt dOUL4GO2XkwisivWiteH3WY= X-Google-Smtp-Source: ABdhPJxpL5KaAnDuQDJzuUb5KCGFxZ3YcW99M+WHBna9dnMuIO92XOsuZyqjUKOy0DftFppakeCj7Q== X-Received: by 2002:a17:902:b210:b029:e6:33b4:cd9e with SMTP id t16-20020a170902b210b02900e633b4cd9emr3418197plr.67.1617809399828; Wed, 07 Apr 2021 08:29:59 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id f65sm22129550pgc.19.2021.04.07.08.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 08:29:58 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 00948402D7; Wed, 7 Apr 2021 15:29:56 +0000 (UTC) Date: Wed, 7 Apr 2021 15:29:56 +0000 From: Luis Chamberlain To: Andy Shevchenko Subject: Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers Message-ID: <20210407152956.GE4332@42.do-not-panic.com> References: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com> <20210406165108.GA4332@42.do-not-panic.com> <20210407143040.GB4332@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Linux on Hyper-V List , Tetsuo Handa , linux-remoteproc@vger.kernel.org, Michael Kelley , Paul Mackerras , "H. Peter Anvin" , Joel Fernandes , "K. Y. Srinivasan" , Thomas Gleixner , Linux-Arch , Wei Liu , Andy Shevchenko , Stephen Hemminger , Corey Minyard , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Ingo Molnar , Iurii Zaikin , Ohad Ben-Cohen , Joerg Roedel , Kees Cook , "Paul E. McKenney" , Lai Jiangshan , Haiyang Zhang , Josh Triplett , "Steven Rostedt \(VMware\)" , rcu@vger.kernel.org, Borislav Petkov , openipmi-developer@lists.sourceforge.net, Bjorn Andersson , Vlastimil Babka , Mathieu Poirier , kexec@lists.infradead.org, Linux Kernel Mailing List , Arnd Bergmann , Eric Biederman , Linux FS Devel , Mathieu Desnoyers , Andrew Morton , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" , Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Apr 07, 2021 at 05:59:19PM +0300, Andy Shevchenko wrote: > On Wed, Apr 7, 2021 at 5:30 PM Luis Chamberlain wrote: > > On Wed, Apr 07, 2021 at 10:33:44AM +0300, Andy Shevchenko wrote: > > > On Wed, Apr 7, 2021 at 10:25 AM Luis Chamberlain wrote: > > > > On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > > ... > > > > > Why is it worth it to add another file just for this? > > > > > > The main point is to break tons of loops that prevent having clean > > > headers anymore. > > > > > > In this case, see bug.h, which is very important in this sense. > > > > OK based on the commit log this was not clear, it seemed more of moving > > panic stuff to its own file, so just cleanup. > > Sorry for that. it should have mentioned the kernel folder instead of > lib. But I think it won't clarify the above. > > In any case there are several purposes in this case > - dropping dependency in bug.h > - dropping a loop by moving out panic_notifier.h > - unload kernel.h from something which has its own domain > > I think that you are referring to the commit message describing 3rd > one, but not 1st and 2nd. Right! > I will amend this for the future splits, thanks! Don't get me wrong, I love the motivation behind just the 3rd purpose, however I figured there might be something more when I saw panic_notifier.h. It was just not clear. But awesome stuff! Luis