From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: pmladek@suse.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, paulus@samba.org,
kan.liang@linux.intel.com, mikey@neuling.org,
maddy@linux.ibm.com, haren@linux.ibm.com, aik@ozlabs.ru,
kjain@linux.ibm.com, ravi.bangoria@linux.ibm.com,
john.ogness@linutronix.de, alistair@popple.id.au,
npiggin@gmail.com, jniethe5@gmail.com,
atrajeev@linux.vnet.ibm.com, Xiongwei Song <sxwjean@me.com>,
Xiongwei Song <sxwjean@gmail.com>,
oleg@redhat.com, aneesh.kumar@linux.ibm.com,
akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org,
rppt@kernel.org
Subject: Re: [PATCH v3] powerpc/traps: Enhance readability for trap types
Date: Sat, 10 Apr 2021 11:46:11 -0500 [thread overview]
Message-ID: <20210410164611.GI26583@gate.crashing.org> (raw)
In-Reply-To: <f0a6713d-756c-86f2-636d-2a478bab9be4@csgroup.eu>
On Sat, Apr 10, 2021 at 11:42:41AM +0200, Christophe Leroy wrote:
> Le 10/04/2021 à 02:04, Michael Ellerman a écrit :
> >I think these can all be avoided by defining most of the values
> >regardless of what platform we're building for. Only the values that
> >overlap need to be kept behind an ifdef.
>
> Even if values overlap we can keep multiple definitions for the same value.
That works, but it can lead to puzzling bugs. Of course we all *like*
working on more challenging bugs, but :-)
Segher
next prev parent reply other threads:[~2021-04-10 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 14:07 [PATCH v3] powerpc/traps: Enhance readability for trap types Xiongwei Song
2021-04-09 16:14 ` Christophe Leroy
2021-04-09 17:45 ` Segher Boessenkool
2021-04-10 0:04 ` Michael Ellerman
2021-04-10 8:33 ` Xiongwei Song
2021-04-10 9:42 ` Christophe Leroy
2021-04-10 16:46 ` Segher Boessenkool [this message]
2021-04-10 8:31 ` Xiongwei Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210410164611.GI26583@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=alistair@popple.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=haren@linux.ibm.com \
--cc=jniethe5@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mikey@neuling.org \
--cc=npiggin@gmail.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rppt@kernel.org \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).