From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B68C433B4 for ; Fri, 21 May 2021 06:23:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEA7B613B6 for ; Fri, 21 May 2021 06:23:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEA7B613B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Fmc4Q2N00z3cVw for ; Fri, 21 May 2021 16:23:34 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Fmc3y1XQsz2xfY for ; Fri, 21 May 2021 16:23:09 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id C508C6736F; Fri, 21 May 2021 08:23:01 +0200 (CEST) Date: Fri, 21 May 2021 08:23:01 +0200 From: Christoph Hellwig To: Coly Li Subject: Re: [PATCH 12/26] bcache: convert to blk_alloc_disk/blk_cleanup_disk Message-ID: <20210521062301.GA10244@lst.de> References: <20210521055116.1053587-1-hch@lst.de> <20210521055116.1053587-13-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ulf Hansson , Mike Snitzer , linux-nvme@lists.infradead.org, Philipp Reisner , Max Filippov , dm-devel@redhat.com, Joshua Morris , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, Dave Jiang , Maxim Levitsky , Vishal Verma , Christoph Hellwig , Christian Borntraeger , Geert Uytterhoeven , Matias Bjorling , Nitin Gupta , Vasily Gorbik , linux-xtensa@linux-xtensa.org, Alex Dubov , Heiko Carstens , linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, Philip Kelleher , Dan Williams , Jens Axboe , Chris Zankel , Song Liu , linux-mmc@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Jim Paris , Minchan Kim , Lars Ellenberg , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 21, 2021 at 02:15:32PM +0800, Coly Li wrote: > The above 2 lines are added on purpose to prevent an refcount > underflow. It is from commit 86da9f736740 ("bcache: fix refcount > underflow in bcache_device_free()"). > > Maybe add a parameter to blk_cleanup_disk() or checking (disk->flags & > GENHD_FL_UP) inside blk_cleanup_disk() ? Please take a look at patch 4 in the series.