From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B6BC2B9F7 for ; Wed, 26 May 2021 04:50:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90B5F613AB for ; Wed, 26 May 2021 04:50:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90B5F613AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FqdmZ74lxz302c for ; Wed, 26 May 2021 14:50:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Fqdm06pDkz2yXl for ; Wed, 26 May 2021 14:49:51 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id 3ADA76736F; Wed, 26 May 2021 06:49:44 +0200 (CEST) Date: Wed, 26 May 2021 06:49:43 +0200 From: Christoph Hellwig To: Ulf Hansson Subject: Re: simplify gendisk and request_queue allocation for bio based drivers Message-ID: <20210526044943.GA28551@lst.de> References: <20210521055116.1053587-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Mike Snitzer , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, linux-bcache@vger.kernel.org, Joshua Morris , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, Dave Jiang , Maxim Levitsky , Vishal Verma , Christoph Hellwig , Christian Borntraeger , Geert Uytterhoeven , Matias Bjorling , Nitin Gupta , Vasily Gorbik , linux-xtensa@linux-xtensa.org, Alex Dubov , Heiko Carstens , Coly Li , linux-block , linux-m68k@lists.linux-m68k.org, Philip Kelleher , Dan Williams , Jens Axboe , Chris Zankel , linux-raid@vger.kernel.org, Max Filippov , linux-mmc , Philipp Reisner , Jim Paris , Minchan Kim , Lars Ellenberg , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, May 26, 2021 at 12:41:37AM +0200, Ulf Hansson wrote: > On Fri, 21 May 2021 at 07:51, Christoph Hellwig wrote: > > > > Hi all, > > > > this series is the first part of cleaning up lifetimes and allocation of > > the gendisk and request_queue structure. It adds a new interface to > > allocate the disk and queue together for bio based drivers, and a helper > > for cleanup/free them when a driver is unloaded or a device is removed. > > May I ask what else you have in the pipe for the next steps? > > The reason why I ask is that I am looking into some issues related to > lifecycle problems of gendisk/mmc, typically triggered at SD/MMC card > removal. In the short run not much more than superficial cleanups. Eventually I want bio based drivers to not require a separate request_queue, leaving that purely as a data structure for blk-mq based drivers. But it will take a while until we get there, so it should not block any fixes. For hot unplug handling it might be worth to take a look at nvme, as it is tested a lot for that case.