* [PATCH 11/15] powerpc: convert to setup_initial_init_mm()
[not found] <20210529105504.180544-1-wangkefeng.wang@huawei.com>
@ 2021-05-29 10:55 ` Kefeng Wang
2021-05-29 12:46 ` Santosh Sivaraj
2021-05-29 16:16 ` Christophe Leroy
0 siblings, 2 replies; 6+ messages in thread
From: Kefeng Wang @ 2021-05-29 10:55 UTC (permalink / raw)
To: Andrew Morton, linux-kernel; +Cc: Kefeng Wang, linuxppc-dev
Use setup_initial_init_mm() helper to simplify code.
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
arch/powerpc/kernel/setup-common.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 046fe21b5c3b..c046d99efd18 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)
klp_init_thread_info(&init_task);
- init_mm.start_code = (unsigned long)_stext;
- init_mm.end_code = (unsigned long) _etext;
- init_mm.end_data = (unsigned long) _edata;
- init_mm.brk = klimit;
+ setup_initial_init_mm(_stext, _etext, _edata, _end);
mm_iommu_init(&init_mm);
irqstack_early_init();
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 11/15] powerpc: convert to setup_initial_init_mm()
2021-05-29 10:55 ` [PATCH 11/15] powerpc: convert to setup_initial_init_mm() Kefeng Wang
@ 2021-05-29 12:46 ` Santosh Sivaraj
2021-05-29 15:22 ` Christophe Leroy
2021-05-29 16:16 ` Christophe Leroy
1 sibling, 1 reply; 6+ messages in thread
From: Santosh Sivaraj @ 2021-05-29 12:46 UTC (permalink / raw)
To: Kefeng Wang, Andrew Morton, linux-kernel; +Cc: Kefeng Wang, linuxppc-dev
Kefeng Wang <wangkefeng.wang@huawei.com> writes:
> Use setup_initial_init_mm() helper to simplify code.
>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> arch/powerpc/kernel/setup-common.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index 046fe21b5c3b..c046d99efd18 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)
>
> klp_init_thread_info(&init_task);
>
> - init_mm.start_code = (unsigned long)_stext;
> - init_mm.end_code = (unsigned long) _etext;
> - init_mm.end_data = (unsigned long) _edata;
> - init_mm.brk = klimit;
> + setup_initial_init_mm(_stext, _etext, _edata, _end);
This function definition is not visible for those who have subscribed only to
linuxppc-dev mailing list. I had to do a web-search with the ID.
Thanks,
Santosh
>
> mm_iommu_init(&init_mm);
> irqstack_early_init();
> --
> 2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 11/15] powerpc: convert to setup_initial_init_mm()
2021-05-29 12:46 ` Santosh Sivaraj
@ 2021-05-29 15:22 ` Christophe Leroy
2021-05-31 1:02 ` Kefeng Wang
0 siblings, 1 reply; 6+ messages in thread
From: Christophe Leroy @ 2021-05-29 15:22 UTC (permalink / raw)
To: Santosh Sivaraj; +Cc: Andrew Morton, linuxppc-dev, linux-kernel, Kefeng Wang
Santosh Sivaraj <santosh@fossix.org> a écrit :
> Kefeng Wang <wangkefeng.wang@huawei.com> writes:
>
>> Use setup_initial_init_mm() helper to simplify code.
I only got that patch, and patchwork as well
(https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=246315)
Can you tell where I can see and get the full series ?
And next time can you copy all patches to linuxppc-dev
Thanks
Christophe
>>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> arch/powerpc/kernel/setup-common.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/setup-common.c
>> b/arch/powerpc/kernel/setup-common.c
>> index 046fe21b5c3b..c046d99efd18 100644
>> --- a/arch/powerpc/kernel/setup-common.c
>> +++ b/arch/powerpc/kernel/setup-common.c
>> @@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)
>>
>> klp_init_thread_info(&init_task);
>>
>> - init_mm.start_code = (unsigned long)_stext;
>> - init_mm.end_code = (unsigned long) _etext;
>> - init_mm.end_data = (unsigned long) _edata;
>> - init_mm.brk = klimit;
>> + setup_initial_init_mm(_stext, _etext, _edata, _end);
>
> This function definition is not visible for those who have subscribed only to
> linuxppc-dev mailing list. I had to do a web-search with the ID.
>
> Thanks,
> Santosh
>
>>
>> mm_iommu_init(&init_mm);
>> irqstack_early_init();
>> --
>> 2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 11/15] powerpc: convert to setup_initial_init_mm()
2021-05-29 10:55 ` [PATCH 11/15] powerpc: convert to setup_initial_init_mm() Kefeng Wang
2021-05-29 12:46 ` Santosh Sivaraj
@ 2021-05-29 16:16 ` Christophe Leroy
2021-05-31 1:05 ` Kefeng Wang
1 sibling, 1 reply; 6+ messages in thread
From: Christophe Leroy @ 2021-05-29 16:16 UTC (permalink / raw)
To: Kefeng Wang; +Cc: Andrew Morton, linuxppc-dev, linux-kernel
Kefeng Wang <wangkefeng.wang@huawei.com> a écrit :
> Use setup_initial_init_mm() helper to simplify code.
>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> arch/powerpc/kernel/setup-common.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup-common.c
> b/arch/powerpc/kernel/setup-common.c
> index 046fe21b5c3b..c046d99efd18 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)
>
> klp_init_thread_info(&init_task);
>
> - init_mm.start_code = (unsigned long)_stext;
> - init_mm.end_code = (unsigned long) _etext;
> - init_mm.end_data = (unsigned long) _edata;
> - init_mm.brk = klimit;
> + setup_initial_init_mm(_stext, _etext, _edata, _end);
This looks wrong, should be klimit instead of _end IIUC
>
> mm_iommu_init(&init_mm);
> irqstack_early_init();
> --
> 2.26.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 11/15] powerpc: convert to setup_initial_init_mm()
2021-05-29 15:22 ` Christophe Leroy
@ 2021-05-31 1:02 ` Kefeng Wang
0 siblings, 0 replies; 6+ messages in thread
From: Kefeng Wang @ 2021-05-31 1:02 UTC (permalink / raw)
To: Christophe Leroy, Santosh Sivaraj
Cc: Andrew Morton, linuxppc-dev, linux-kernel
On 2021/5/29 23:22, Christophe Leroy wrote:
> Santosh Sivaraj <santosh@fossix.org> a écrit :
>
>> Kefeng Wang <wangkefeng.wang@huawei.com> writes:
>>
>>> Use setup_initial_init_mm() helper to simplify code.
>
> I only got that patch, and patchwork as well
> (https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=246315)
>
> Can you tell where I can see and get the full series ?
>
> And next time can you copy all patches to linuxppc-dev
ok, will be careful next time, thank for your reminding.
>
> Thanks
> Christophe
>
>>>
>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>> Cc: linuxppc-dev@lists.ozlabs.org
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> ---
>>> arch/powerpc/kernel/setup-common.c | 5 +----
>>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>>
>>> diff --git a/arch/powerpc/kernel/setup-common.c
>>> b/arch/powerpc/kernel/setup-common.c
>>> index 046fe21b5c3b..c046d99efd18 100644
>>> --- a/arch/powerpc/kernel/setup-common.c
>>> +++ b/arch/powerpc/kernel/setup-common.c
>>> @@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)
>>>
>>> klp_init_thread_info(&init_task);
>>>
>>> - init_mm.start_code = (unsigned long)_stext;
>>> - init_mm.end_code = (unsigned long) _etext;
>>> - init_mm.end_data = (unsigned long) _edata;
>>> - init_mm.brk = klimit;
>>> + setup_initial_init_mm(_stext, _etext, _edata, _end);
>>
>> This function definition is not visible for those who have subscribed
>> only to
>> linuxppc-dev mailing list. I had to do a web-search with the ID.
>>
>> Thanks,
>> Santosh
>>
>>>
>>> mm_iommu_init(&init_mm);
>>> irqstack_early_init();
>>> --
>>> 2.26.2
>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 11/15] powerpc: convert to setup_initial_init_mm()
2021-05-29 16:16 ` Christophe Leroy
@ 2021-05-31 1:05 ` Kefeng Wang
0 siblings, 0 replies; 6+ messages in thread
From: Kefeng Wang @ 2021-05-31 1:05 UTC (permalink / raw)
To: Christophe Leroy; +Cc: Andrew Morton, linuxppc-dev, linux-kernel
On 2021/5/30 0:16, Christophe Leroy wrote:
> Kefeng Wang <wangkefeng.wang@huawei.com> a écrit :
>
>> Use setup_initial_init_mm() helper to simplify code.
>>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> arch/powerpc/kernel/setup-common.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/arch/powerpc/kernel/setup-common.c
>> b/arch/powerpc/kernel/setup-common.c
>> index 046fe21b5c3b..c046d99efd18 100644
>> --- a/arch/powerpc/kernel/setup-common.c
>> +++ b/arch/powerpc/kernel/setup-common.c
>> @@ -928,10 +928,7 @@ void __init setup_arch(char **cmdline_p)
>>
>> klp_init_thread_info(&init_task);
>>
>> - init_mm.start_code = (unsigned long)_stext;
>> - init_mm.end_code = (unsigned long) _etext;
>> - init_mm.end_data = (unsigned long) _edata;
>> - init_mm.brk = klimit;
>> + setup_initial_init_mm(_stext, _etext, _edata, _end);
>
> This looks wrong, should be klimit instead of _end IIUC
see arch/powerpc/kernel/setup-common.c:
unsigned long klimit = (unsigned long) _end;
the setup_initial_init_mm helper [1] should use the original _end
+static inline void setup_initial_init_mm(char *start_code,
+ char *end_code,
+ char *end_data,
+ char *brk)
+{
+ init_mm.start_code = (unsigned long)start_code;
+ init_mm.end_code = (unsigned long)end_code;
+ init_mm.end_data = (unsigned long)end_data;
+ init_mm.brk = (unsigned long)brk;
+}
[1] https://lkml.org/lkml/2021/5/29/84
>
>>
>> mm_iommu_init(&init_mm);
>> irqstack_early_init();
>> --
>> 2.26.2
>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-31 1:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210529105504.180544-1-wangkefeng.wang@huawei.com>
2021-05-29 10:55 ` [PATCH 11/15] powerpc: convert to setup_initial_init_mm() Kefeng Wang
2021-05-29 12:46 ` Santosh Sivaraj
2021-05-29 15:22 ` Christophe Leroy
2021-05-31 1:02 ` Kefeng Wang
2021-05-29 16:16 ` Christophe Leroy
2021-05-31 1:05 ` Kefeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).