* [PATCH] powerpc/8xx: select CPM1 for MPC8XXFADS
@ 2021-06-01 17:53 trix
2021-06-02 7:44 ` Christophe Leroy
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2021-06-01 17:53 UTC (permalink / raw)
To: christophe.leroy, mpe, benh, paulus; +Cc: Tom Rix, linuxppc-dev, linux-kernel
From: Tom Rix <trix@redhat.com>
With MPC8XXFADS, there is this linker error
ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade':
m8xx_setup.c: undefined reference to `cpm_get_irq'
cpm_get_irq() is conditionally complied by CPM1
So add a select, like the other plaforms
Signed-off-by: Tom Rix <trix@redhat.com>
---
arch/powerpc/platforms/8xx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/8xx/Kconfig b/arch/powerpc/platforms/8xx/Kconfig
index 60cc5b537a98..919082cdb2f1 100644
--- a/arch/powerpc/platforms/8xx/Kconfig
+++ b/arch/powerpc/platforms/8xx/Kconfig
@@ -10,6 +10,7 @@ choice
config MPC8XXFADS
bool "FADS"
+ select CPM1
config MPC86XADS
bool "MPC86XADS"
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/8xx: select CPM1 for MPC8XXFADS
2021-06-01 17:53 [PATCH] powerpc/8xx: select CPM1 for MPC8XXFADS trix
@ 2021-06-02 7:44 ` Christophe Leroy
2021-06-02 22:10 ` Tom Rix
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2021-06-02 7:44 UTC (permalink / raw)
To: trix, mpe, benh, paulus; +Cc: linuxppc-dev, linux-kernel
Le 01/06/2021 à 19:53, trix@redhat.com a écrit :
> From: Tom Rix <trix@redhat.com>
>
> With MPC8XXFADS, there is this linker error
> ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade':
> m8xx_setup.c: undefined reference to `cpm_get_irq'
It looks like this config item is stale, it doesn't build any board support, there is no
define_machine() for this config item, no file is linked to that config item.
I think you should just remove that item from the possible choices.
Christophe
>
> cpm_get_irq() is conditionally complied by CPM1
> So add a select, like the other plaforms
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> arch/powerpc/platforms/8xx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/platforms/8xx/Kconfig b/arch/powerpc/platforms/8xx/Kconfig
> index 60cc5b537a98..919082cdb2f1 100644
> --- a/arch/powerpc/platforms/8xx/Kconfig
> +++ b/arch/powerpc/platforms/8xx/Kconfig
> @@ -10,6 +10,7 @@ choice
>
> config MPC8XXFADS
> bool "FADS"
> + select CPM1
>
> config MPC86XADS
> bool "MPC86XADS"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/8xx: select CPM1 for MPC8XXFADS
2021-06-02 7:44 ` Christophe Leroy
@ 2021-06-02 22:10 ` Tom Rix
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rix @ 2021-06-02 22:10 UTC (permalink / raw)
To: Christophe Leroy, mpe, benh, paulus; +Cc: linuxppc-dev, linux-kernel
On 6/2/21 12:44 AM, Christophe Leroy wrote:
>
>
> Le 01/06/2021 à 19:53, trix@redhat.com a écrit :
>> From: Tom Rix <trix@redhat.com>
>>
>> With MPC8XXFADS, there is this linker error
>> ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade':
>> m8xx_setup.c: undefined reference to `cpm_get_irq'
>
> It looks like this config item is stale, it doesn't build any board
> support, there is no define_machine() for this config item, no file is
> linked to that config item.
>
> I think you should just remove that item from the possible choices.
>
Yes, this looks like a dead config and removing it is what to do.
I withdraw this change.
I am looking at sweeping the tree of dead configs.
Up a dir, my finder shows
PPC_MMU_NOHASH_32
is another (maybe) dead config.
Thanks for pointing this out,
Tom
> Christophe
>
>
>>
>> cpm_get_irq() is conditionally complied by CPM1
>> So add a select, like the other plaforms
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> arch/powerpc/platforms/8xx/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/platforms/8xx/Kconfig
>> b/arch/powerpc/platforms/8xx/Kconfig
>> index 60cc5b537a98..919082cdb2f1 100644
>> --- a/arch/powerpc/platforms/8xx/Kconfig
>> +++ b/arch/powerpc/platforms/8xx/Kconfig
>> @@ -10,6 +10,7 @@ choice
>> config MPC8XXFADS
>> bool "FADS"
>> + select CPM1
>> config MPC86XADS
>> bool "MPC86XADS"
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-02 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-01 17:53 [PATCH] powerpc/8xx: select CPM1 for MPC8XXFADS trix
2021-06-02 7:44 ` Christophe Leroy
2021-06-02 22:10 ` Tom Rix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).