From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8ADBC4338F for ; Thu, 5 Aug 2021 17:37:07 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC49D610A2 for ; Thu, 5 Aug 2021 17:37:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC49D610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GgbQT2fFcz3dCY for ; Fri, 6 Aug 2021 03:37:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=cmarinas@kernel.org; receiver=) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GgbQ34RxNz3cHQ for ; Fri, 6 Aug 2021 03:36:43 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0683E610A2; Thu, 5 Aug 2021 17:36:32 +0000 (UTC) Date: Thu, 5 Aug 2021 18:36:25 +0100 From: Catalin Marinas To: Lee Jones Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Message-ID: <20210805173625.GH6719@arm.com> References: <20210805075032.723037-1-lee.jones@linaro.org> <20210805075032.723037-2-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210805075032.723037-2-lee.jones@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Greg Kroah-Hartman , John Crispin , Sebastian Reichel , "James E . J . Bottomley" , Max Filippov , Guo Ren , linux-csky@vger.kernel.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , Thomas Gleixner , Anton Ivanov , Jonas Bonn , linux-s390@vger.kernel.org, Brian Cain , Helge Deller , linux-sh@vger.kernel.org, Ley Foon Tan , Christian Borntraeger , Ingo Molnar , Geert Uytterhoeven , linux-snps-arc@lists.infradead.org, Jeff Dike , uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Albert Ou , Vasily Gorbik , Heiko Carstens , linux-um@lists.infradead.org, Stefan Kristiansson , linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , Paul Walmsley , Stafford Horne , linux-arm-kernel@lists.infradead.org, Chris Zankel , Michal Simek , Thomas Bogendoerfer , linux-mips@vger.kernel.org, Yoshinori Sato , linux-parisc@vger.kernel.org, Vineet Gupta , linux-kernel@vger.kernel.org, Palmer Dabbelt , Richard Weinberger , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Aug 05, 2021 at 08:50:30AM +0100, Lee Jones wrote: > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index b4bb67f17a2ca..cf89ce91d7145 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -212,6 +212,7 @@ void machine_restart(char *cmd) > printk("Reboot failed -- System halted\n"); > while (1); > } > +EXPORT_SYMBOL(machine_restart); Should we make this EXPORT_SYMBOL_GPL? I suppose it's not for general use by out of tree drivers and it matches the other pm_power_off symbol we export in this file. Either way: Acked-by: Catalin Marinas