linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Kajol Jain <kjain@linux.ibm.com>
To: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org
Cc: kjain@linux.ibm.com, atrajeev@linux.vnet.ibm.com,
	maddy@linux.ibm.com, rnsastry@linux.ibm.com
Subject: [PATCH v2 2/2] powerpc/perf: Return regs->nip as instruction pointer value when SIAR is 0
Date: Fri, 13 Aug 2021 13:54:50 +0530	[thread overview]
Message-ID: <20210813082450.429320-2-kjain@linux.ibm.com> (raw)
In-Reply-To: <20210813082450.429320-1-kjain@linux.ibm.com>

Incase of random sampling, there can be scenarios where SIAR is not
latching sample address and results in 0 value. Since current code
directly returning the siar value, we could see multiple instruction
pointer values as 0 in perf report.
Patch resolves this issue by adding a ternary condition to return
regs->nip incase SIAR is 0.

Fixes: 75382aa72f06 ("powerpc/perf: Move code to select SIAR or pt_regs
into perf_read_regs")
Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
---
 arch/powerpc/perf/core-book3s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
index 1b464aad29c4..aeecaaf6810f 100644
--- a/arch/powerpc/perf/core-book3s.c
+++ b/arch/powerpc/perf/core-book3s.c
@@ -2260,7 +2260,7 @@ unsigned long perf_instruction_pointer(struct pt_regs *regs)
 		else
 			return regs->nip;
 	} else if (use_siar && siar_valid(regs))
-		return siar + perf_ip_adjust(regs);
+		return siar ? siar + perf_ip_adjust(regs) : regs->nip;
 	else if (use_siar)
 		return 0;		// no valid instruction pointer
 	else
-- 
2.26.2


  reply	other threads:[~2021-08-13  8:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13  8:24 [PATCH v2 1/2] powerpc/perf: Use stack siar instead of mfspr Kajol Jain
2021-08-13  8:24 ` Kajol Jain [this message]
2021-08-13  9:29   ` [PATCH v2 2/2] powerpc/perf: Return regs->nip as instruction pointer value when SIAR is 0 Christophe Leroy
2021-08-14 12:25     ` Michael Ellerman
2021-08-13  9:34   ` Christophe Leroy
2021-08-14 12:44     ` Michael Ellerman
2021-08-16  6:44       ` kajoljain
2021-08-16  6:56         ` Christophe Leroy
2021-08-17  5:37           ` Madhavan Srinivasan
2021-08-17  8:29             ` kajoljain
2021-08-17 12:49           ` Michael Ellerman
2021-08-16  6:46     ` kajoljain
2021-08-13  8:29 ` [PATCH v2 1/2] powerpc/perf: Use stack siar instead of mfspr kajoljain
2021-08-13  9:23   ` Christophe Leroy
2021-08-14 12:30     ` Michael Ellerman
2021-08-16  5:58       ` kajoljain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210813082450.429320-2-kjain@linux.ibm.com \
    --to=kjain@linux.ibm.com \
    --cc=atrajeev@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=rnsastry@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).