From: Bjorn Helgaas <helgaas@kernel.org>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: linux-kernel@vger.kernel.org, paulus@samba.org,
linux-pci@vger.kernel.org, bhelgaas@google.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] pci/hotplug/pnv-php: Remove probable double put
Date: Tue, 7 Sep 2021 06:24:05 -0500 [thread overview]
Message-ID: <20210907112405.GA722145@bjorn-Precision-5520> (raw)
In-Reply-To: <20210907085946.21694-1-vulab@iscas.ac.cn>
Make your subject line follow the previous convention.
Figure out if this is a "probable" or a real double put. If it's a
real double put, we should fix it. If it's only "probable," that
means we don't understand the problem yet.
On Tue, Sep 07, 2021 at 08:59:46AM +0000, Xu Wang wrote:
> Device node iterators put the previous value of the index variable,
> so an explicit put causes a double put.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/pci/hotplug/pnv_php.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c
> index 04565162a449..ed4d1a2c3f22 100644
> --- a/drivers/pci/hotplug/pnv_php.c
> +++ b/drivers/pci/hotplug/pnv_php.c
> @@ -158,7 +158,6 @@ static void pnv_php_detach_device_nodes(struct device_node *parent)
> for_each_child_of_node(parent, dn) {
> pnv_php_detach_device_nodes(dn);
>
> - of_node_put(dn);
> of_detach_node(dn);
> }
> }
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-09-07 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 8:59 [PATCH] pci/hotplug/pnv-php: Remove probable double put Xu Wang
2021-09-07 11:24 ` Bjorn Helgaas [this message]
2021-09-07 22:01 ` Tyrel Datwyler
2021-09-07 23:17 ` Oliver O'Halloran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907112405.GA722145@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox