From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: linuxppc-dev@lists.ozlabs.org
Cc: Frederic Barrat <fbarrat@linux.ibm.com>,
Brian King <brking@linux.ibm.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Leonardo Bras <leobras.c@gmail.com>
Subject: [PATCH kernel 2/4] powerpc/pseries/iommu: Use correct vfree for it_map
Date: Thu, 21 Oct 2021 00:23:13 +1100 [thread overview]
Message-ID: <20211020132315.2287178-3-aik@ozlabs.ru> (raw)
In-Reply-To: <20211020132315.2287178-1-aik@ozlabs.ru>
The it_map array is vzalloc'ed so use vfree() for it when creating
a huge DMA window failed for whatever reason.
While at this, write zero to it_map.
Fixes: 381ceda88c4c ("powerpc/pseries/iommu: Make use of DDW for indirect mapping")
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
arch/powerpc/platforms/pseries/iommu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c
index 09d59088864a..45564547cd80 100644
--- a/arch/powerpc/platforms/pseries/iommu.c
+++ b/arch/powerpc/platforms/pseries/iommu.c
@@ -1440,7 +1440,8 @@ static bool enable_ddw(struct pci_dev *dev, struct device_node *pdn)
/* Keep default DMA window stuct if removed */
if (default_win_removed) {
tbl->it_size = 0;
- kfree(tbl->it_map);
+ vfree(tbl->it_map);
+ tbl->it_map = NULL;
}
set_iommu_table_base(&dev->dev, newtbl);
--
2.30.2
next prev parent reply other threads:[~2021-10-20 13:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 13:23 [PATCH kernel 0/4] Fixes for powerpc/pseries/iommu: Make use of DDW for indirect mapping Alexey Kardashevskiy
2021-10-20 13:23 ` [PATCH kernel 1/4] powerpc/pseries/iommu: Fix indentations Alexey Kardashevskiy
2021-10-20 13:23 ` Alexey Kardashevskiy [this message]
2021-10-20 13:23 ` [PATCH kernel 3/4] powerpc/pseries/iommu: Check if the default window in use before removing it Alexey Kardashevskiy
2021-10-20 13:23 ` [PATCH kernel 4/4] powerpc/pseries/iommu: Create huge DMA window if no MMIO32 is present Alexey Kardashevskiy
2021-11-02 2:43 ` [PATCH kernel 0/4] Fixes for powerpc/pseries/iommu: Make use of DDW for indirect mapping Michael Ellerman
2021-11-17 10:19 ` Frederic Barrat
2021-11-17 10:58 ` Frederic Barrat
2021-11-17 13:01 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020132315.2287178-3-aik@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=brking@linux.ibm.com \
--cc=fbarrat@linux.ibm.com \
--cc=leobras.c@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).