From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D6EC433F5 for ; Thu, 4 Nov 2021 11:37:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92DA3611CE for ; Thu, 4 Nov 2021 11:37:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 92DA3611CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HlM7p6lYyz2ymr for ; Thu, 4 Nov 2021 22:37:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4HlM7G6BMHz2xtW for ; Thu, 4 Nov 2021 22:37:13 +1100 (AEDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1A4BXrIY010918; Thu, 4 Nov 2021 06:33:53 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 1A4BXpu3010915; Thu, 4 Nov 2021 06:33:51 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 4 Nov 2021 06:33:51 -0500 From: Segher Boessenkool To: Stephen Rothwell Subject: Re: [PATCH] powerpc: use swap() to make code cleaner Message-ID: <20211104113351.GK614@gate.crashing.org> References: <20211104061709.1505592-1-yang.guang5@zte.com.cn> <20211104210637.3c424bcc@elm.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211104210637.3c424bcc@elm.ozlabs.ibm.com> User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sxwjean@gmail.com, aneesh.kumar@linux.ibm.com, Zeal Robot , davidcomponentone@gmail.com, linux-kernel@vger.kernel.org, nathan@kernel.org, yang.guang5@zte.com.cn, paulus@samba.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Nov 04, 2021 at 09:06:56PM +1100, Stephen Rothwell wrote: > On Thu, 4 Nov 2021 14:17:09 +0800 davidcomponentone@gmail.com wrote: > > From: Yang Guang > > > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid > > opencoding it. > > So if swap() is in the above include file, then you should include it. It is included from kernel.h already (which is included from delay.h). Segher