linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: davidcomponentone@gmail.com
Cc: sfr@canb.auug.org.au, sxwjean@gmail.com,
	Zeal Robot <zealci@zte.com.cn>,
	linux-kernel@vger.kernel.org, nathan@kernel.org,
	yang.guang5@zte.com.cn, paulus@samba.org,
	aneesh.kumar@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: use swap() to make code cleaner
Date: Thu, 4 Nov 2021 21:06:56 +1100	[thread overview]
Message-ID: <20211104210637.3c424bcc@elm.ozlabs.ibm.com> (raw)
In-Reply-To: <20211104061709.1505592-1-yang.guang5@zte.com.cn>

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

Hi,

On Thu,  4 Nov 2021 14:17:09 +0800 davidcomponentone@gmail.com wrote:
>
> From: Yang Guang <yang.guang5@zte.com.cn>
> 
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.

So if swap() is in the above include file, then you should include it.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-11-04 10:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04  6:17 [PATCH] powerpc: use swap() to make code cleaner davidcomponentone
2021-11-04 10:06 ` Stephen Rothwell [this message]
2021-11-04 11:33   ` Segher Boessenkool
2021-11-04 20:26     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2021-12-18  1:59 davidcomponentone
2021-12-26 21:52 ` Michael Ellerman
2021-11-04  1:09 davidcomponentone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211104210637.3c424bcc@elm.ozlabs.ibm.com \
    --to=sfr@canb.auug.org.au \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=davidcomponentone@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nathan@kernel.org \
    --cc=paulus@samba.org \
    --cc=sxwjean@gmail.com \
    --cc=yang.guang5@zte.com.cn \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).