From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7232FC433F5 for ; Fri, 5 Nov 2021 17:59:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D40C60FE3 for ; Fri, 5 Nov 2021 17:59:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8D40C60FE3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hm7Z90BXZz3c7C for ; Sat, 6 Nov 2021 04:59:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hm7Yh4xmzz2yp6 for ; Sat, 6 Nov 2021 04:59:18 +1100 (AEDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1A5Hw3s4018233; Fri, 5 Nov 2021 12:58:03 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 1A5Hw1tI018232; Fri, 5 Nov 2021 12:58:01 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 5 Nov 2021 12:58:01 -0500 From: Segher Boessenkool To: Finn Thain Subject: Re: Fwd: Fwd: X stopped working with 5.14 on iBook Message-ID: <20211105175801.GO614@gate.crashing.org> References: <6919111c-02fa-c6b9-bb05-04161e52f340@yahoo.com> <27ad38f3-c1a8-ac5c-8467-f311b5882a00@yahoo.com> <48c3ed15-2ecf-cc12-c287-2b61457f5fb@nippy.intranet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Christopher M. Riedl" , Stan Johnson , linuxppc-dev@lists.ozlabs.org, Riccardo Mottola Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Nov 05, 2021 at 10:36:18AM +1100, Finn Thain wrote: > There is no __get_user_asm2_goto in this tree, and __get_user_asm2 already > has the "=&r" constraint: > > #define __get_user_asm2(x, addr, err) \ > __asm__ __volatile__( \ > "1: lwz%X2 %1, %2\n" \ > "2: lwz%X2 %L1, %L2\n" \ > "3:\n" \ > ".section .fixup,\"ax\"\n" \ > "4: li %0,%3\n" \ > " li %1,0\n" \ > " li %1+1,0\n" \ > " b 3b\n" \ > ".previous\n" \ > EX_TABLE(1b, 4b) \ > EX_TABLE(2b, 4b) \ > : "=r" (err), "=&r" (x) \ > : "m" (*addr), "i" (-EFAULT), "0" (err)) operand 0 needs an earlyclobber as well, in principle. But there is nothing left it can be tied to, so this won't change generated code. What is operand 4 about? It isn't used? The "%1+1" can be written %L1 btw (it means exactly the same thing, but work on more configs). Segher