linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ganesh Goudar <ganeshgr@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au
Cc: Ganesh Goudar <ganeshgr@linux.ibm.com>,
	kbuild-all@lists.01.org, mahesh@linux.ibm.com, npiggin@gmail.com,
	dja@axtens.net
Subject: Re: [PATCH v2 1/2] powerpc/mce: Avoid using irq_work_queue() in realmode
Date: Wed, 24 Nov 2021 17:25:33 +0800	[thread overview]
Message-ID: <202111241736.ZgcO0Sk3-lkp@intel.com> (raw)
In-Reply-To: <20211124050311.64959-1-ganeshgr@linux.ibm.com>

Hi Ganesh,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.16-rc2 next-20211124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ganesh-Goudar/powerpc-mce-Avoid-using-irq_work_queue-in-realmode/20211124-130459
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20211124/202111241736.ZgcO0Sk3-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/bac24ec52edd7013115ad594974f64a30565266d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ganesh-Goudar/powerpc-mce-Avoid-using-irq_work_queue-in-realmode/20211124-130459
        git checkout bac24ec52edd7013115ad594974f64a30565266d
        # save the config file to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/time.c: In function '____timer_interrupt':
>> arch/powerpc/kernel/time.c:598:25: error: implicit declaration of function 'mce_run_late_handlers' [-Werror=implicit-function-declaration]
     598 |                         mce_run_late_handlers();
         |                         ^~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/mce_run_late_handlers +598 arch/powerpc/kernel/time.c

   590	
   591		old_regs = set_irq_regs(regs);
   592	
   593		trace_timer_interrupt_entry(regs);
   594	
   595		if (test_irq_work_pending()) {
   596			clear_irq_work_pending();
   597			if (IS_ENABLED(CONFIG_PPC_BOOK3S_64))
 > 598				mce_run_late_handlers();
   599			irq_work_run();
   600		}
   601	
   602		now = get_tb();
   603		if (now >= *next_tb) {
   604			*next_tb = ~(u64)0;
   605			if (evt->event_handler)
   606				evt->event_handler(evt);
   607			__this_cpu_inc(irq_stat.timer_irqs_event);
   608		} else {
   609			now = *next_tb - now;
   610			if (now <= decrementer_max)
   611				set_dec(now);
   612			/* We may have raced with new irq work */
   613			if (test_irq_work_pending())
   614				set_dec(1);
   615			__this_cpu_inc(irq_stat.timer_irqs_others);
   616		}
   617	
   618		trace_timer_interrupt_exit(regs);
   619	
   620		set_irq_regs(old_regs);
   621	}
   622	EXPORT_SYMBOL(timer_interrupt);
   623	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

      parent reply	other threads:[~2021-11-24  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24  5:03 [PATCH v2 1/2] powerpc/mce: Avoid using irq_work_queue() in realmode Ganesh Goudar
2021-11-24  5:03 ` [PATCH v2 2/2] pseries/mce: Refactor the pseries mce handling code Ganesh Goudar
2021-11-24  9:25 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202111241736.ZgcO0Sk3-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dja@axtens.net \
    --cc=ganeshgr@linux.ibm.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).