linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail.com>
Subject: [PATCH v4 14/17] powerpc/64s: Fix radix MMU when MMU_FTR_HPTE_TABLE is clear
Date: Thu, 25 Nov 2021 22:50:22 +1000	[thread overview]
Message-ID: <20211125125025.1472060-15-npiggin@gmail.com> (raw)
In-Reply-To: <20211125125025.1472060-1-npiggin@gmail.com>

There are a few places that require MMU_FTR_HPTE_TABLE to be set even
when running in radix mode. Fix those up.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 arch/powerpc/mm/pgtable.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
index ce9482383144..abb3198bd277 100644
--- a/arch/powerpc/mm/pgtable.c
+++ b/arch/powerpc/mm/pgtable.c
@@ -81,9 +81,6 @@ static struct page *maybe_pte_to_page(pte_t pte)
 
 static pte_t set_pte_filter_hash(pte_t pte)
 {
-	if (radix_enabled())
-		return pte;
-
 	pte = __pte(pte_val(pte) & ~_PAGE_HPTEFLAGS);
 	if (pte_looks_normal(pte) && !(cpu_has_feature(CPU_FTR_COHERENT_ICACHE) ||
 				       cpu_has_feature(CPU_FTR_NOEXECUTE))) {
@@ -112,6 +109,9 @@ static inline pte_t set_pte_filter(pte_t pte)
 {
 	struct page *pg;
 
+	if (radix_enabled())
+		return pte;
+
 	if (mmu_has_feature(MMU_FTR_HPTE_TABLE))
 		return set_pte_filter_hash(pte);
 
@@ -144,6 +144,9 @@ static pte_t set_access_flags_filter(pte_t pte, struct vm_area_struct *vma,
 {
 	struct page *pg;
 
+	if (IS_ENABLED(CONFIG_PPC_BOOK3S_64))
+		return pte;
+
 	if (mmu_has_feature(MMU_FTR_HPTE_TABLE))
 		return pte;
 
-- 
2.23.0


  parent reply	other threads:[~2021-11-25 13:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 12:50 [PATCH v4 00/17] powerpc: Make hash MMU code build configurable Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 01/17] powerpc: Remove unused FW_FEATURE_NATIVE references Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 02/17] powerpc: Rename PPC_NATIVE to PPC_HASH_MMU_NATIVE Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 03/17] powerpc/pseries: Stop selecting PPC_HASH_MMU_NATIVE Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 04/17] powerpc/64s: Move and rename do_bad_slb_fault as it is not hash specific Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 05/17] powerpc/pseries: move process table registration away from hash-specific code Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 06/17] powerpc/pseries: lparcfg don't include slb_size line in radix mode Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 07/17] powerpc/64s: move THP trace point creation out of hash specific file Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 08/17] powerpc/64s: Make flush_and_reload_slb a no-op when radix is enabled Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 09/17] powerpc/64s: move page size definitions from hash specific file Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 10/17] powerpc/64s: Rename hash_hugetlbpage.c to hugetlbpage.c Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 11/17] powerpc/64: pcpu setup avoid reading mmu_linear_psize on 64e or radix Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 12/17] powerpc: make memremap_compat_align 64s-only Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 13/17] powerpc/64e: remove mmu_linear_psize Nicholas Piggin
2021-11-25 12:50 ` Nicholas Piggin [this message]
2021-11-25 12:50 ` [PATCH v4 15/17] powerpc/64s: Make hash MMU support configurable Nicholas Piggin
2021-11-25 12:50 ` [PATCH v4 16/17] powerpc/64s: Move hash MMU support code under CONFIG_PPC_64S_HASH_MMU Nicholas Piggin
2021-11-25 19:28   ` kernel test robot
2021-11-25 12:50 ` [PATCH v4 17/17] powerpc/microwatt: add POWER9_CPU, clear PPC_64S_HASH_MMU Nicholas Piggin
2021-11-25 16:35 ` [PATCH v4 00/17] powerpc: Make hash MMU code build configurable Christophe Leroy
2021-11-25 17:35   ` Christophe Leroy
2021-11-26  0:55     ` Nicholas Piggin
2021-11-26  7:20       ` Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211125125025.1472060-15-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).