From: Segher Boessenkool <segher@kernel.crashing.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "masahiroy@kernel.org" <masahiroy@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 1/3] powerpc/vdso: augment VDSO32 functions to support 64 bits build
Date: Tue, 21 Dec 2021 13:36:08 -0600 [thread overview]
Message-ID: <20211221193608.GD614@gate.crashing.org> (raw)
In-Reply-To: <09b25a22cd5179eba4580ae95414f18fc162bedf.1640108961.git.christophe.leroy@csgroup.eu>
On Tue, Dec 21, 2021 at 05:49:33PM +0000, Christophe Leroy wrote:
> diff --git a/arch/powerpc/kernel/vdso32/datapage.S b/arch/powerpc/kernel/vdso32/datapage.S
> index 65244416ab94..db8e167f0166 100644
> --- a/arch/powerpc/kernel/vdso32/datapage.S
> +++ b/arch/powerpc/kernel/vdso32/datapage.S
> @@ -30,11 +30,15 @@ V_FUNCTION_BEGIN(__kernel_get_syscall_map)
> mr. r4,r3
> get_datapage r3
> mtlr r12
> +#ifdef __powerpc64__
> + addi r3,r3,CFG_SYSCALL_MAP64
> +#else
> addi r3,r3,CFG_SYSCALL_MAP32
> +#endif
> + crclr cr0*4+so
> beqlr
> li r0,NR_syscalls
> stw r0,0(r4)
> - crclr cr0*4+so
> blr
This now clears cr0.3 if r3 is zero on entry. Is that on purpose?
Rest looks good.
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
Segher
next prev parent reply other threads:[~2021-12-21 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 17:49 [PATCH 1/3] powerpc/vdso: augment VDSO32 functions to support 64 bits build Christophe Leroy
2021-12-21 17:49 ` [PATCH 2/3] powerpc/vdso: Rework VDSO32 makefile to add a prefix to object files Christophe Leroy
2021-12-21 17:49 ` [PATCH 3/3] powerpc/vdso: Merge vdso64 and vdso32 into a single directory Christophe Leroy
2021-12-22 9:25 ` kernel test robot
2021-12-22 9:50 ` Christophe Leroy
2021-12-21 19:36 ` Segher Boessenkool [this message]
2021-12-22 7:36 ` [PATCH 1/3] powerpc/vdso: augment VDSO32 functions to support 64 bits build Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211221193608.GD614@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).