From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 200A9C433EF for ; Wed, 12 Jan 2022 16:10:06 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JYswD4vnLz3bZX for ; Thu, 13 Jan 2022 03:10:04 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JYsvn5pmKz2xMw for ; Thu, 13 Jan 2022 03:09:41 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id 3EE0868AFE; Wed, 12 Jan 2022 17:09:36 +0100 (CET) Date: Wed, 12 Jan 2022 17:09:35 +0100 From: Christoph Hellwig To: Arnd Bergmann Subject: Re: [PATCH 4/5] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h Message-ID: <20220112160935.GA3684@lst.de> References: <20220111083515.502308-1-hch@lst.de> <20220111083515.502308-5-hch@lst.de> <20220112075609.GA4854@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , linux-s390 , Parisc List , the arch/x86 maintainers , Jeff Layton , Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , "J. Bruce Fields" , Guo Ren , sparclinux , linuxppc-dev , Christoph Hellwig , Linux ARM Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Jan 12, 2022 at 01:08:24PM +0100, Arnd Bergmann wrote: > > I don't have a strong opinion here. If we were taking symbols away that > > were previously visible to userland it would be one thing, but since > > we're just adding symbols that may not have been there before, this > > seems less likely to break anything. > > Changing > > #ifndef CONFIG_64BIT > > to > > #if __BITS_PER_LONG==32 || defined(__KERNEL__), > > would take symbols away, since the CONFIG_64BIT macro is never > set in user space. Yes. > > I probably lean toward Christoph's original solution instead of keeping > > the conditional definitions. It's hard to imagine there are many > > programs that care whether these other symbols are defined or not. > > > > You can add this to the original patch: > > > > Acked-by: Jeff Layton > > Sounds good, thanks So should we go ahead with the series as-is? Or respin it? Or add the above change ontop?