From: Christoph Hellwig <hch@lst.de>
To: guoren@kernel.org
Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Guo Ren <guoren@linux.alibaba.com>,
linux-parisc@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, drew@beagleboard.org,
anup@brainfault.org, wangjunqiang@iscas.ac.cn, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
linux-mips@vger.kernel.org, palmer@dabbelt.com,
liush@allwinnertech.com, sparclinux@vger.kernel.org,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
hch@lst.de, linux-arm-kernel@lists.infradead.org,
wefu@redhat.com
Subject: Re: [PATCH V5 15/21] riscv: compat: Add hw capability check for elf
Date: Wed, 2 Feb 2022 08:51:59 +0100 [thread overview]
Message-ID: <20220202075159.GB18398@lst.de> (raw)
In-Reply-To: <20220201150545.1512822-16-guoren@kernel.org>
On Tue, Feb 01, 2022 at 11:05:39PM +0800, guoren@kernel.org wrote:
> +bool compat_elf_check_arch(Elf32_Ehdr *hdr)
> +{
> + if (compat_mode_support && (hdr->e_machine == EM_RISCV))
> + return true;
> + else
> + return false;
> +}
This can be simplified to:
return compat_mode_support && hdr->e_machine == EM_RISCV;
I'd also rename compat_mode_support to compat_mode_supported
> +
> +static int compat_mode_detect(void)
> +{
> + unsigned long tmp = csr_read(CSR_STATUS);
> +
> + csr_write(CSR_STATUS, (tmp & ~SR_UXL) | SR_UXL_32);
> +
> + if ((csr_read(CSR_STATUS) & SR_UXL) != SR_UXL_32) {
> + pr_info("riscv: 32bit compat mode detect failed\n");
> + compat_mode_support = false;
> + } else {
> + compat_mode_support = true;
> + pr_info("riscv: 32bit compat mode detected\n");
> + }
I don't think we need these printks here.
Also this could be simplified to:
compat_mode_supported = (csr_read(CSR_STATUS) & SR_UXL) == SR_UXL_32;
next prev parent reply other threads:[~2022-02-02 7:52 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 15:05 [PATCH V5 00/21] riscv: compat: Add COMPAT mode support for rv64 guoren
2022-02-01 15:05 ` [PATCH V5 01/21] uapi: simplify __ARCH_FLOCK{,64}_PAD a little guoren
2022-02-01 15:05 ` [PATCH V5 02/21] uapi: always define F_GETLK64/F_SETLK64/F_SETLKW64 in fcntl.h guoren
2022-02-01 15:05 ` [PATCH V5 03/21] compat: consolidate the compat_flock{, 64} definition guoren
2022-02-01 15:05 ` [PATCH V5 04/21] kconfig: Add SYSVIPC_COMPAT for all architectures guoren
2022-02-01 15:05 ` [PATCH V5 05/21] fs: stat: compat: Add __ARCH_WANT_COMPAT_STAT guoren
2022-02-01 15:05 ` [PATCH V5 06/21] asm-generic: compat: Cleanup duplicate definitions guoren
2022-02-02 7:48 ` Christoph Hellwig
2022-02-01 15:05 ` [PATCH V5 07/21] syscalls: compat: Fix the missing part for __SYSCALL_COMPAT guoren
2022-02-01 15:05 ` [PATCH V5 08/21] riscv: Fixup difference with defconfig guoren
2022-02-01 15:05 ` [PATCH V5 09/21] riscv: compat: Add basic compat data type implementation guoren
2022-02-23 1:42 ` Palmer Dabbelt
2022-02-23 8:54 ` Guo Ren
2022-02-01 15:05 ` [PATCH V5 10/21] riscv: compat: Re-implement TASK_SIZE for COMPAT_32BIT guoren
2022-02-01 15:05 ` [PATCH V5 11/21] riscv: compat: syscall: Add compat_sys_call_table implementation guoren
2022-02-01 15:05 ` [PATCH V5 12/21] riscv: compat: syscall: Add entry.S implementation guoren
2022-02-23 1:42 ` Palmer Dabbelt
2022-02-01 15:05 ` [PATCH V5 13/21] riscv: compat: process: Add UXL_32 support in start_thread guoren
2022-02-23 1:42 ` Palmer Dabbelt
2022-02-23 9:21 ` Guo Ren
2022-02-01 15:05 ` [PATCH V5 14/21] riscv: compat: Add elf.h implementation guoren
2022-02-01 15:05 ` [PATCH V5 15/21] riscv: compat: Add hw capability check for elf guoren
2022-02-02 2:02 ` Guo Ren
2022-02-02 7:51 ` Christoph Hellwig [this message]
2022-02-03 2:44 ` Guo Ren
2022-02-01 15:05 ` [PATCH V5 16/21] riscv: compat: vdso: Add rv32 VDSO base code implementation guoren
2022-02-23 1:42 ` Palmer Dabbelt
2022-02-23 9:55 ` Guo Ren
2022-02-01 15:05 ` [PATCH V5 17/21] riscv: compat: vdso: Add setup additional pages implementation guoren
2022-02-23 1:42 ` Palmer Dabbelt
2022-02-23 11:49 ` Guo Ren
2022-02-24 1:36 ` Guo Ren
[not found] ` <4379941.LvFx2qVVIh@eto.sf-tec.de>
2022-02-23 12:42 ` Guo Ren
2022-02-01 15:05 ` [PATCH V5 18/21] riscv: compat: signal: Add rt_frame implementation guoren
2022-02-23 1:42 ` Palmer Dabbelt
2022-02-01 15:05 ` [PATCH V5 19/21] riscv: compat: ptrace: Add compat_arch_ptrace implement guoren
2022-02-23 1:42 ` Palmer Dabbelt
2022-02-01 15:05 ` [PATCH V5 20/21] riscv: compat: Add COMPAT Kbuild skeletal support guoren
2022-02-01 15:05 ` [PATCH V5 21/21] KVM: compat: riscv: Prevent KVM_COMPAT from being selected guoren
2022-02-01 15:44 ` Anup Patel
2022-02-01 16:00 ` Paolo Bonzini
2022-02-01 16:11 ` Anup Patel
2022-02-01 16:16 ` Guo Ren
2022-02-23 1:42 ` Palmer Dabbelt
2022-02-08 7:43 ` [PATCH V5 00/21] riscv: compat: Add COMPAT mode support for rv64 Guo Ren
2022-02-23 1:43 ` Palmer Dabbelt
2022-02-23 10:59 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202075159.GB18398@lst.de \
--to=hch@lst.de \
--cc=anup@brainfault.org \
--cc=arnd@arndb.de \
--cc=drew@beagleboard.org \
--cc=gregkh@linuxfoundation.org \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liush@allwinnertech.com \
--cc=palmer@dabbelt.com \
--cc=sparclinux@vger.kernel.org \
--cc=wangjunqiang@iscas.ac.cn \
--cc=wefu@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).