From: Christoph Hellwig <hch@lst.de>
To: Zi Yan <ziy@nvidia.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
David Hildenbrand <david@redhat.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
iommu@lists.linux-foundation.org, Mike Rapoport <rppt@kernel.org>,
Eric Ren <renzhengeek@gmail.com>,
Oscar Salvador <osalvador@suse.de>,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>, Vlastimil Babka <vbabka@suse.cz>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v5 3/6] mm: make alloc_contig_range work at pageblock granularity
Date: Mon, 14 Feb 2022 08:26:01 +0100 [thread overview]
Message-ID: <20220214072601.GA17306@lst.de> (raw)
In-Reply-To: <20220211164135.1803616-4-zi.yan@sent.com>
> +int
> +isolate_single_pageblock(unsigned long boundary_pfn, gfp_t gfp_flags, int isolate_before_boundary);
Please avoid the completely unreadably long line. i.e.
int isolate_single_pageblock(unsigned long boundary_pfn, gfp_t gfp_flags,
int isolate_before_boundary);
Same in various other spots.
next prev parent reply other threads:[~2022-02-14 7:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 16:41 [PATCH v5 0/6] Use pageblock_order for cma and alloc_contig_range alignment Zi Yan
2022-02-11 16:41 ` [PATCH v5 1/6] mm: page_isolation: move has_unmovable_pages() to mm/page_isolation.c Zi Yan
2022-02-14 10:44 ` Mike Rapoport
2022-02-11 16:41 ` [PATCH v5 2/6] mm: page_isolation: check specified range for unmovable pages Zi Yan
2022-02-11 16:41 ` [PATCH v5 3/6] mm: make alloc_contig_range work at pageblock granularity Zi Yan
2022-02-14 7:26 ` Christoph Hellwig [this message]
2022-02-14 15:46 ` Zi Yan
2022-02-14 7:59 ` Christophe Leroy
2022-02-14 16:03 ` Zi Yan
2022-02-11 16:41 ` [PATCH v5 4/6] mm: cma: use pageblock_order as the single alignment Zi Yan
2022-02-11 16:41 ` [PATCH v5 5/6] drivers: virtio_mem: use pageblock size as the minimum virtio_mem size Zi Yan
2022-02-11 16:41 ` [PATCH v5 6/6] arch: powerpc: adjust fadump alignment to be pageblock aligned Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214072601.GA17306@lst.de \
--to=hch@lst.de \
--cc=david@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=renzhengeek@gmail.com \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=virtualization@lists.linux-foundation.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).