From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C2C8C433F5 for ; Thu, 17 Feb 2022 18:11:32 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4K02vk2p4Cz3clL for ; Fri, 18 Feb 2022 05:11:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4K02vF64Dfz3cNt for ; Fri, 18 Feb 2022 05:11:04 +1100 (AEDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 21HI7aqe029714; Thu, 17 Feb 2022 12:07:36 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 21HI7Z7l029713; Thu, 17 Feb 2022 12:07:35 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 17 Feb 2022 12:07:35 -0600 From: Segher Boessenkool To: Masahiro Yamada Subject: Re: [PATCH net v3] net: Force inlining of checksum functions in net/checksum.h Message-ID: <20220217180735.GM614@gate.crashing.org> References: <978951d76d8cb84bab347c7623bc163e9a038452.1645100305.git.christophe.leroy@csgroup.eu> <35bcd5df0fb546008ff4043dbea68836@AcuMS.aculab.com> <9b8ef186-c7fe-822c-35df-342c9e86cc88@csgroup.eu> <3c2b682a7d804b5e8749428b50342c82@AcuMS.aculab.com> <2e38265880db45afa96cfb51223f7418@AcuMS.aculab.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , Nick Desaulniers , "linux-kernel@vger.kernel.org" , "David S. Miller" , David Laight , Jakub Kicinski , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , Ingo Molnar Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Feb 18, 2022 at 02:27:16AM +0900, Masahiro Yamada wrote: > On Fri, Feb 18, 2022 at 1:49 AM David Laight wrote: > > That description is largely fine. > > > > Inappropriate 'inline' ought to be removed. > > Then 'inline' means - 'really do inline this'. > > You cannot change "static inline" to "static" > in header files. Why not? Those two have identical semantics! Segher