linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anders Roxell <anders.roxell@linaro.org>
To: mpe@ellerman.id.au
Cc: Arnd Bergmann <arnd@arndb.de>,
	Anders Roxell <anders.roxell@linaro.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: [PATCH 3/3] powerpc: lib: sstep: fix build errors
Date: Wed, 23 Feb 2022 14:58:20 +0100	[thread overview]
Message-ID: <20220223135820.2252470-3-anders.roxell@linaro.org> (raw)
In-Reply-To: <20220223135820.2252470-1-anders.roxell@linaro.org>

Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian
2.37.90.20220207) the following build error shows up:

{standard input}: Assembler messages:
{standard input}:10576: Error: unrecognized opcode: `stbcx.'
{standard input}:10680: Error: unrecognized opcode: `lharx'
{standard input}:10694: Error: unrecognized opcode: `lbarx'

Rework to add assembler directives [1] around the instruction.  The
problem with this might be that we can trick a power6 into
single-stepping through an stbcx. for instance, and it will execute that
in kernel mode.

[1] https://sourceware.org/binutils/docs/as/PowerPC_002dPseudo.html#PowerPC_002dPseudo

Cc: <stable@vger.kernel.org>
Co-developed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 arch/powerpc/lib/sstep.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c
index d2d29243fa6d..b9f43bbdd55a 100644
--- a/arch/powerpc/lib/sstep.c
+++ b/arch/powerpc/lib/sstep.c
@@ -1097,7 +1097,10 @@ NOKPROBE_SYMBOL(emulate_dcbz);
 
 #define __put_user_asmx(x, addr, err, op, cr)		\
 	__asm__ __volatile__(				\
+		".machine \"push\"\n"			\
+		".machine \"power8\"\n"			\
 		"1:	" op " %2,0,%3\n"		\
+		".machine \"pop\"\n"			\
 		"	mfcr	%1\n"			\
 		"2:\n"					\
 		".section .fixup,\"ax\"\n"		\
@@ -1110,7 +1113,10 @@ NOKPROBE_SYMBOL(emulate_dcbz);
 
 #define __get_user_asmx(x, addr, err, op)		\
 	__asm__ __volatile__(				\
+		".machine \"push\"\n"			\
+		".machine \"power8\"\n"			\
 		"1:	"op" %1,0,%2\n"			\
+		".machine \"pop\"\n"			\
 		"2:\n"					\
 		".section .fixup,\"ax\"\n"		\
 		"3:	li	%0,%3\n"		\
-- 
2.34.1


  parent reply	other threads:[~2022-02-23 14:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 13:58 [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Anders Roxell
2022-02-23 13:58 ` [PATCH 2/3] powerpc: fix build errors Anders Roxell
2022-02-23 15:21   ` Segher Boessenkool
2022-02-24  2:54   ` Nicholas Piggin
2022-02-24  5:05     ` Nicholas Piggin
2022-02-24  8:55       ` Arnd Bergmann
2022-02-24 10:11         ` Nicholas Piggin
2022-02-24 10:20           ` Arnd Bergmann
2022-02-24 11:13             ` Nicholas Piggin
2022-02-24 17:29               ` Segher Boessenkool
2022-02-25  0:23                 ` Nicholas Piggin
2022-02-25 22:28                   ` Segher Boessenkool
2022-02-26  0:07                     ` Nicholas Piggin
2022-02-24 17:12       ` Segher Boessenkool
2022-02-25  0:32         ` Nicholas Piggin
2022-02-25  8:33           ` Arnd Bergmann
2022-02-25 10:51             ` Nicholas Piggin
2022-02-25 22:33           ` Segher Boessenkool
2022-02-24 12:39   ` Michael Ellerman
2022-02-24 16:12     ` Anders Roxell
2022-02-24 17:37     ` Segher Boessenkool
2022-02-23 13:58 ` Anders Roxell [this message]
2022-02-23 15:27   ` [PATCH 3/3] powerpc: lib: sstep: " Segher Boessenkool
2022-02-24  2:40 ` [PATCH 1/3] powerpc: lib: sstep: fix 'sthcx' instruction Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220223135820.2252470-3-anders.roxell@linaro.org \
    --to=anders.roxell@linaro.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).