From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FE22C433F5 for ; Thu, 24 Feb 2022 17:40:45 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4K4Kty6twnz3bcC for ; Fri, 25 Feb 2022 04:40:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4K4KtW4Sn5z30LY for ; Fri, 25 Feb 2022 04:40:19 +1100 (AEDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 21OHbDJC020019; Thu, 24 Feb 2022 11:37:13 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 21OHbDNV020018; Thu, 24 Feb 2022 11:37:13 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 24 Feb 2022 11:37:13 -0600 From: Segher Boessenkool To: Michael Ellerman Subject: Re: [PATCH 2/3] powerpc: fix build errors Message-ID: <20220224173713.GO614@gate.crashing.org> References: <20220223135820.2252470-1-anders.roxell@linaro.org> <20220223135820.2252470-2-anders.roxell@linaro.org> <871qzsphfv.fsf@mpe.ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qzsphfv.fsf@mpe.ellerman.id.au> User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org, Anders Roxell , linux-kernel@vger.kernel.org, Arnd Bergmann Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Feb 24, 2022 at 11:39:16PM +1100, Michael Ellerman wrote: > > /* Calculate the parity of the value */ > > - asm ("popcntd %0,%1" : "=r" (parity) : "r" (val)); > > + asm (".machine \"push\"\n" > > + ".machine \"power7\"\n" > > + "popcntd %0,%1\n" > > + ".machine \"pop\"\n" > > + : "=r" (parity) : "r" (val)); > > This was actually present in an older CPU, but it doesn't really matter, > this is fine. popcntd was new on p7 (popcntb is the older one :-) ) And it does not matter indeed. Segher