From: Hangyu Hua <hbh25y@gmail.com>
To: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Hangyu Hua <hbh25y@gmail.com>
Subject: [PATCH] powerpc: kernel: fix a refcount leak in format_show()
Date: Mon, 28 Feb 2022 17:11:03 +0800 [thread overview]
Message-ID: <20220228091103.39749-1-hbh25y@gmail.com> (raw)
node needs to be dropped when of_property_read_string fails. So an earlier call
to of_node_put is required here.
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
arch/powerpc/kernel/secvar-sysfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c
index a0a78aba2083..cd0fa7028d86 100644
--- a/arch/powerpc/kernel/secvar-sysfs.c
+++ b/arch/powerpc/kernel/secvar-sysfs.c
@@ -30,13 +30,12 @@ static ssize_t format_show(struct kobject *kobj, struct kobj_attribute *attr,
return -ENODEV;
rc = of_property_read_string(node, "format", &format);
+ of_node_put(node);
if (rc)
return rc;
rc = sprintf(buf, "%s\n", format);
- of_node_put(node);
-
return rc;
}
--
2.25.1
next reply other threads:[~2022-02-28 9:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 9:11 Hangyu Hua [this message]
2022-03-01 12:55 ` [PATCH] powerpc: kernel: fix a refcount leak in format_show() Michael Ellerman
2022-03-01 19:50 ` Tyrel Datwyler
2022-03-02 1:34 ` Hangyu Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220228091103.39749-1-hbh25y@gmail.com \
--to=hbh25y@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).