From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28E74C433EF for ; Thu, 17 Mar 2022 15:47:25 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KKBNX18X8z3bf6 for ; Fri, 18 Mar 2022 02:47:24 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=permerror (SPF Permanent Error: Void lookup limit of 2 exceeded) smtp.mailfrom=mansr.com (client-ip=2001:8b0:ca0d:8d8e::2; helo=unicorn.mansr.com; envelope-from=mru@mansr.com; receiver=) X-Greylist: delayed 434 seconds by postgrey-1.36 at boromir; Fri, 18 Mar 2022 02:46:59 AEDT Received: from unicorn.mansr.com (unicorn.mansr.com [IPv6:2001:8b0:ca0d:8d8e::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KKBN34C8lz30CS for ; Fri, 18 Mar 2022 02:46:59 +1100 (AEDT) Received: from raven.mansr.com (raven.mansr.com [81.2.72.235]) by unicorn.mansr.com (Postfix) with ESMTPS id EF05B15360; Thu, 17 Mar 2022 15:39:35 +0000 (GMT) Received: by raven.mansr.com (Postfix, from userid 51770) id 86495210BC8; Thu, 17 Mar 2022 15:39:35 +0000 (GMT) From: Mans Rullgard To: Pantelis Antoniou , "David S. Miller" , Jakub Kicinski , Vitaly Bordug , Dan Malek , Joakim Tjernlund , linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC][PATCH] net: fs_enet: fix tx error handling Date: Thu, 17 Mar 2022 15:38:58 +0000 Message-Id: <20220317153858.20719-1-mans@mansr.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" In some cases, the TXE flag is apparently set without any error indication in the buffer descriptor status. When this happens, tx stalls until the tx_restart() function is called via the device watchdog which can take a long time. To fix this, check for TXE in the napi poll function and trigger a tx_restart() call as for errors reported in the buffer descriptor. This change makes the FCC based Ethernet controller on MPC82xx devices usable. It probably breaks the other modes (FEC, SCC) which I have no way of testing. Signed-off-by: Mans Rullgard --- .../ethernet/freescale/fs_enet/fs_enet-main.c | 47 +++++++------------ .../net/ethernet/freescale/fs_enet/mac-fcc.c | 2 +- 2 files changed, 19 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c index 78e008b81374..4276becd07cf 100644 --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c @@ -94,14 +94,22 @@ static int fs_enet_napi(struct napi_struct *napi, int budget) int curidx; int dirtyidx, do_wake, do_restart; int tx_left = TX_RING_SIZE; + u32 int_events; spin_lock(&fep->tx_lock); bdp = fep->dirty_tx; + do_wake = do_restart = 0; + + int_events = (*fep->ops->get_int_events)(dev); + + if (int_events & fep->ev_err) { + (*fep->ops->ev_error)(dev, int_events); + do_restart = 1; + } /* clear status bits for napi*/ (*fep->ops->napi_clear_event)(dev); - do_wake = do_restart = 0; while (((sc = CBDR_SC(bdp)) & BD_ENET_TX_READY) == 0 && tx_left) { dirtyidx = bdp - fep->tx_bd_base; @@ -318,43 +326,24 @@ fs_enet_interrupt(int irq, void *dev_id) { struct net_device *dev = dev_id; struct fs_enet_private *fep; - const struct fs_platform_info *fpi; u32 int_events; - u32 int_clr_events; - int nr, napi_ok; - int handled; fep = netdev_priv(dev); - fpi = fep->fpi; - nr = 0; - while ((int_events = (*fep->ops->get_int_events)(dev)) != 0) { - nr++; + int_events = (*fep->ops->get_int_events)(dev); + if (!int_events) + return IRQ_NONE; - int_clr_events = int_events; - int_clr_events &= ~fep->ev_napi; + int_events &= ~fep->ev_napi; - (*fep->ops->clear_int_events)(dev, int_clr_events); - - if (int_events & fep->ev_err) - (*fep->ops->ev_error)(dev, int_events); - - if (int_events & fep->ev) { - napi_ok = napi_schedule_prep(&fep->napi); - - (*fep->ops->napi_disable)(dev); - (*fep->ops->clear_int_events)(dev, fep->ev_napi); - - /* NOTE: it is possible for FCCs in NAPI mode */ - /* to submit a spurious interrupt while in poll */ - if (napi_ok) - __napi_schedule(&fep->napi); - } + (*fep->ops->clear_int_events)(dev, int_events); + if (napi_schedule_prep(&fep->napi)) { + (*fep->ops->napi_disable)(dev); + __napi_schedule(&fep->napi); } - handled = nr > 0; - return IRQ_RETVAL(handled); + return IRQ_HANDLED; } void fs_init_bds(struct net_device *dev) diff --git a/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c b/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c index b47490be872c..66c8f82a8333 100644 --- a/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c +++ b/drivers/net/ethernet/freescale/fs_enet/mac-fcc.c @@ -124,7 +124,7 @@ static int do_pd_setup(struct fs_enet_private *fep) return ret; } -#define FCC_NAPI_EVENT_MSK (FCC_ENET_RXF | FCC_ENET_RXB | FCC_ENET_TXB) +#define FCC_NAPI_EVENT_MSK (FCC_ENET_RXF | FCC_ENET_RXB | FCC_ENET_TXB | FCC_ENET_TXE) #define FCC_EVENT (FCC_ENET_RXF | FCC_ENET_TXB) #define FCC_ERR_EVENT_MSK (FCC_ENET_TXE) -- 2.35.1