From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37177C433EF for ; Mon, 28 Mar 2022 13:36:58 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KRtyw51pJz3c79 for ; Tue, 29 Mar 2022 00:36:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4KRtxn34B7z3c0T for ; Tue, 29 Mar 2022 00:35:56 +1100 (AEDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 22SDJU00005431; Mon, 28 Mar 2022 08:19:30 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 22SDJSov005423; Mon, 28 Mar 2022 08:19:28 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 28 Mar 2022 08:19:28 -0500 From: Segher Boessenkool To: Arnd Bergmann Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers Message-ID: <20220328131928.GH614@gate.crashing.org> References: <20220326165909.506926-1-benni@stuerz.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , "open list:ACPI COMPONENT ARCHITECTURE \(ACPICA\)" , linux-atm-general@lists.sourceforge.net, linux-ia64@vger.kernel.org, linux-pci , Linus Walleij , Dave Hansen , Russell King - ARM Linux , Krzysztof Kozlowski , Alim Akhtar , "H. Peter Anvin" , wcn36xx@lists.infradead.org, Bartosz Golaszewski , Benjamin =?iso-8859-1?Q?St=FCrz?= , Jason Gunthorpe , Pkshih , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , dennis.dalessandro@cornelisnetworks.com, linux-rdma , Gregory CLEMENT , "Rafael J. Wysocki" , Robert Moore , Harald Welte , ACPI Devel Maling List , Ingo Molnar , Sebastian Hesselbarth , Chas Williams <3chas3@gmail.com>, "open list:HID CORE LAYER" , Jakub Kicinski , pabeni@redhat.com, Len Brown , mike.marciniszyn@cornelisnetworks.com, Robert Richter , Andrew Donnellan , kvalo@kernel.org, "open list:GPIO SUBSYSTEM" , Tony Luck , Borislav Petkov , Bjorn Helgaas , Thomas Gleixner , Mauro Carvalho Chehab , Simtec Linux Team , Linux ARM , linux-edac@vger.kernel.org, Karsten Keil , loic.poulain@linaro.org, Pali =?iso-8859-1?Q?Roh=E1r?= , Nicolas Pitre , gregkh , Dmitry Torokhov , linux-wireless , Linux Kernel Mailing List , James Morse , Networking , Frederic Barrat , Linux Media Mailing List , linuxppc-dev , David Miller Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Mar 26, 2022 at 08:23:31PM +0100, Arnd Bergmann wrote: > On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz wrote: > > > > This replaces comments with C99's designated > > initializers because the kernel supports them now. > > The change looks fine, but the comment looks misplaced, as enum initializers > are not c99 feature. Yes, it is from C89/C90. > Also, the named array and struct intializers have been > supported by gnu89 for a long time and widely used in the kernel, so it's > not a recent change even for the others. GCC supports this since 1998. There was a syntax different from C99 designated initializers (".ans = 42") before (namely, "ans: 42"). 1998 is long enough ago for all intents and purposes now of course ;-) Segher