* [PATCH kernel] powerpc/perf: Fix 32bit compile
@ 2022-04-21 2:57 Alexey Kardashevskiy
2022-04-24 12:15 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Kardashevskiy @ 2022-04-21 2:57 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Alexey Kardashevskiy
The "read_bhrb" global symbol is only called under CONFIG_PPC64 of
arch/powerpc/perf/core-book3s.c but it is compiled for both 32 and 64 bit
anyway (and LLVM fails to link this on 32bit).
This fixes it by moving bhrb.o to obj64 targets.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
arch/powerpc/perf/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile
index 2f46e31c7612..4f53d0b97539 100644
--- a/arch/powerpc/perf/Makefile
+++ b/arch/powerpc/perf/Makefile
@@ -3,11 +3,11 @@
obj-y += callchain.o callchain_$(BITS).o perf_regs.o
obj-$(CONFIG_COMPAT) += callchain_32.o
-obj-$(CONFIG_PPC_PERF_CTRS) += core-book3s.o bhrb.o
+obj-$(CONFIG_PPC_PERF_CTRS) += core-book3s.o
obj64-$(CONFIG_PPC_PERF_CTRS) += ppc970-pmu.o power5-pmu.o \
power5+-pmu.o power6-pmu.o power7-pmu.o \
isa207-common.o power8-pmu.o power9-pmu.o \
- generic-compat-pmu.o power10-pmu.o
+ generic-compat-pmu.o power10-pmu.o bhrb.o
obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o
obj-$(CONFIG_PPC_POWERNV) += imc-pmu.o
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH kernel] powerpc/perf: Fix 32bit compile
2022-04-21 2:57 [PATCH kernel] powerpc/perf: Fix 32bit compile Alexey Kardashevskiy
@ 2022-04-24 12:15 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2022-04-24 12:15 UTC (permalink / raw)
To: linuxppc-dev, Alexey Kardashevskiy
On Thu, 21 Apr 2022 12:57:56 +1000, Alexey Kardashevskiy wrote:
> The "read_bhrb" global symbol is only called under CONFIG_PPC64 of
> arch/powerpc/perf/core-book3s.c but it is compiled for both 32 and 64 bit
> anyway (and LLVM fails to link this on 32bit).
>
> This fixes it by moving bhrb.o to obj64 targets.
>
>
> [...]
Applied to powerpc/fixes.
[1/1] powerpc/perf: Fix 32bit compile
https://git.kernel.org/powerpc/c/bb82c574691daf8f7fa9a160264d15c5804cb769
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-24 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-21 2:57 [PATCH kernel] powerpc/perf: Fix 32bit compile Alexey Kardashevskiy
2022-04-24 12:15 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).