From: Steven Rostedt <rostedt@goodmis.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
Nick Desaulniers <ndesaulniers@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 2/2] recordmcount: Handle sections with no non-weak symbols
Date: Wed, 4 May 2022 13:06:42 -0400 [thread overview]
Message-ID: <20220504130642.7b9a301d@rorschach.local.home> (raw)
In-Reply-To: <72d17597-874c-f3a3-9398-0cc944350c5b@csgroup.eu>
On Wed, 4 May 2022 16:50:58 +0000
Christophe Leroy <christophe.leroy@csgroup.eu> wrote:
> In vmlinux, relocations are resolved, trampolines are installed for
> unreachable destinations and you don't anymore have a section with all
> the relocations to mcount. It means 'recordmcount' or whatever tool we
> use will have to read the code to find all direct calls to mcount, then
> find all trampolines to mcount then find all calls to those trampolines.
OK, so what you are saying is that in the object file, we can see the
site that calls mcount, but when it is linked, it may not call mcount,
but instead it will call a trampoline that will call mcount, thus the
tool will need to find these calls to the trampolines that call mcount
as well as the locations that call mcount directly.
Did I get that right?
-- Steve
next prev parent reply other threads:[~2022-05-04 17:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 9:31 [PATCH 0/2] ftrace/recordmcount: Handle object files without section symbols Naveen N. Rao
2022-04-27 9:31 ` [PATCH 1/2] ftrace: Drop duplicate mcount locations Naveen N. Rao
2022-04-27 13:46 ` Steven Rostedt
2022-04-27 9:31 ` [PATCH 2/2] recordmcount: Handle sections with no non-weak symbols Naveen N. Rao
2022-04-27 13:54 ` Steven Rostedt
2022-04-28 7:45 ` Naveen N. Rao
2022-04-28 14:06 ` Steven Rostedt
2022-04-28 17:24 ` Naveen N. Rao
2022-04-28 17:31 ` Naveen N. Rao
2022-05-02 14:44 ` Christophe Leroy
2022-05-02 23:52 ` Steven Rostedt
2022-05-03 11:20 ` Christophe Leroy
2022-05-03 16:25 ` Steven Rostedt
2022-05-04 16:50 ` Christophe Leroy
2022-05-04 17:06 ` Steven Rostedt [this message]
2022-05-04 17:10 ` Christophe Leroy
2022-08-16 14:04 ` [PATCH 0/2] ftrace/recordmcount: Handle object files without section symbols Steven Rostedt
2022-08-16 17:05 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504130642.7b9a301d@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).