From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD930C433F5 for ; Fri, 13 May 2022 19:01:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4L0J051gf3z3cF8 for ; Sat, 14 May 2022 05:01:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=npoWGyvu; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ricardo.neri-calderon@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=npoWGyvu; dkim-atps=neutral Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4L0HzN14sRz2xrS for ; Sat, 14 May 2022 05:00:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652468448; x=1684004448; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8jZEDO0wap/S70A6rQv+pSQuvwOwjW4+QKi9OH+Emho=; b=npoWGyvud5wAOdze56YO+dYt1geEFYqYw8OktNOM74HIpRaWkj7POy0Q 6JtJfTHKNDS2Fr4wsjRB1jtr9N+s/rRqkneTCvlvm5DdpsZ3fsA8bm2Nm uhoEICkedGS+OVEDyz9PTZ5OYuNrgEMDjxGhw3RavbgmysNTnSpgfR1m5 9jvWo+RXQCrTbrT4i2iD4jlkEnHfjxBBXW8/zJudFaRuFtnQPeXmXOO+o m3MpMAiz+9/soRFqRImp2mqZr/MI3Epprzf9D2c+G94yiWnwL9nWTyH9q UcooSYiVCBFPtbsqqAIlhCUBBr3DMiTtXzAZiYTNlRtRyJ8hJ45mWnWx2 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10346"; a="295647690" X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="295647690" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 11:59:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,223,1647327600"; d="scan'208";a="698603603" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by orsmga004.jf.intel.com with ESMTP; 13 May 2022 11:59:44 -0700 Date: Fri, 13 May 2022 12:03:19 -0700 From: Ricardo Neri To: Thomas Gleixner Subject: Re: [PATCH v6 13/29] iommu/amd: Compose MSI messages for NMI irqs in non-IR format Message-ID: <20220513190319.GD22683@ranerica-svr.sc.intel.com> References: <20220506000008.30892-1-ricardo.neri-calderon@linux.intel.com> <20220506000008.30892-14-ricardo.neri-calderon@linux.intel.com> <87r156fiur.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r156fiur.ffs@tglx> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Ravi V. Shankar" , Andi Kleen , linuxppc-dev@lists.ozlabs.org, Joerg Roedel , x86@kernel.org, Ricardo Neri , Stephane Eranian , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Tony Luck , Nicholas Piggin , Suravee Suthikulpanit , Andrew Morton , David Woodhouse , Lu Baolu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 06, 2022 at 11:31:56PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > + * > > + * Also, NMIs do not have an associated vector. No need for cleanup. > > They have a vector and what the heck is this cleanup comment for here? > There is nothing cleanup alike anywhere near. > > Adding confusing comments is worse than adding no comments at all. I will remove the comment regarding cleanup. I will clarify that NMI has a fixed vector. Thanks and BR, Ricardo