* [PATCH] powerpc/vdso: Fix __kernel_sync_dicache sequence with coherent icache
@ 2022-05-20 12:36 Nicholas Piggin
2022-07-29 13:02 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Piggin @ 2022-05-20 12:36 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Nicholas Piggin
Processors with coherent icache require the sequence sync ; icbi ; isync
to entire store->execute coherency. icbi (to any address) must be
executed to ensure isync flushes the pipeline. See "POWER9 Processor
User's Manual, 4.6.2.2 Instruction Cache Block Invalidate (icbi)" for
details.
__kernel_sync_dicache is missing icbi for the coherent icache path.
Add it.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
arch/powerpc/kernel/vdso/cacheflush.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/vdso/cacheflush.S b/arch/powerpc/kernel/vdso/cacheflush.S
index d4e43ab2d5df..0085ae464dac 100644
--- a/arch/powerpc/kernel/vdso/cacheflush.S
+++ b/arch/powerpc/kernel/vdso/cacheflush.S
@@ -91,6 +91,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE)
3:
crclr cr0*4+so
sync
+ icbi 0,r1
isync
li r3,0
blr
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc/vdso: Fix __kernel_sync_dicache sequence with coherent icache
2022-05-20 12:36 [PATCH] powerpc/vdso: Fix __kernel_sync_dicache sequence with coherent icache Nicholas Piggin
@ 2022-07-29 13:02 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2022-07-29 13:02 UTC (permalink / raw)
To: Nicholas Piggin, linuxppc-dev
On Fri, 20 May 2022 22:36:49 +1000, Nicholas Piggin wrote:
> Processors with coherent icache require the sequence sync ; icbi ; isync
> to entire store->execute coherency. icbi (to any address) must be
> executed to ensure isync flushes the pipeline. See "POWER9 Processor
> User's Manual, 4.6.2.2 Instruction Cache Block Invalidate (icbi)" for
> details.
>
> __kernel_sync_dicache is missing icbi for the coherent icache path.
> Add it.
>
> [...]
Applied to powerpc/next.
[1/1] powerpc/vdso: Fix __kernel_sync_dicache sequence with coherent icache
https://git.kernel.org/powerpc/c/28f07fab26319dacc5675ae01dfc84d82122c59b
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-29 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-20 12:36 [PATCH] powerpc/vdso: Fix __kernel_sync_dicache sequence with coherent icache Nicholas Piggin
2022-07-29 13:02 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).