* [PATCH] powerpc/64s: Don't read H_BLOCK_REMOVE characteristics in radix mode
@ 2022-05-20 15:57 Laurent Dufour
2022-05-20 16:15 ` Christophe Leroy
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Dufour @ 2022-05-20 15:57 UTC (permalink / raw)
To: mpe, npiggin; +Cc: aneesh.kumar, linuxppc-dev, linux-kernel
There is no need to read the H_BLOCK_REMOVE characteristics when running in
Radix mode because this hcall is never called.
Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
---
arch/powerpc/platforms/pseries/setup.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
index c9fcc30a0365..654d2b999c25 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -803,7 +803,8 @@ static void __init pSeries_setup_arch(void)
pseries_setup_security_mitigations();
#ifdef CONFIG_PPC_64S_HASH_MMU
- pseries_lpar_read_hblkrm_characteristics();
+ if (!radix_enabled())
+ pseries_lpar_read_hblkrm_characteristics();
#endif
/* By default, only probe PCI (can be overridden by rtas_pci) */
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/64s: Don't read H_BLOCK_REMOVE characteristics in radix mode
2022-05-20 15:57 [PATCH] powerpc/64s: Don't read H_BLOCK_REMOVE characteristics in radix mode Laurent Dufour
@ 2022-05-20 16:15 ` Christophe Leroy
2022-05-23 16:09 ` Laurent Dufour
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2022-05-20 16:15 UTC (permalink / raw)
To: Laurent Dufour, mpe@ellerman.id.au, npiggin@gmail.com
Cc: aneesh.kumar@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Le 20/05/2022 à 17:57, Laurent Dufour a écrit :
> There is no need to read the H_BLOCK_REMOVE characteristics when running in
> Radix mode because this hcall is never called.
>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> ---
> arch/powerpc/platforms/pseries/setup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
> index c9fcc30a0365..654d2b999c25 100644
> --- a/arch/powerpc/platforms/pseries/setup.c
> +++ b/arch/powerpc/platforms/pseries/setup.c
> @@ -803,7 +803,8 @@ static void __init pSeries_setup_arch(void)
>
> pseries_setup_security_mitigations();
> #ifdef CONFIG_PPC_64S_HASH_MMU
> - pseries_lpar_read_hblkrm_characteristics();
> + if (!radix_enabled())
> + pseries_lpar_read_hblkrm_characteristics();
> #endif
As far as I can see the function always exists so the #ifdef can be removed.
>
> /* By default, only probe PCI (can be overridden by rtas_pci) */
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/64s: Don't read H_BLOCK_REMOVE characteristics in radix mode
2022-05-20 16:15 ` Christophe Leroy
@ 2022-05-23 16:09 ` Laurent Dufour
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Dufour @ 2022-05-23 16:09 UTC (permalink / raw)
To: Christophe Leroy, mpe@ellerman.id.au, npiggin@gmail.com
Cc: aneesh.kumar@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
On 20/05/2022, 18:15:39, Christophe Leroy wrote:
>
>
> Le 20/05/2022 à 17:57, Laurent Dufour a écrit :
>> There is no need to read the H_BLOCK_REMOVE characteristics when running in
>> Radix mode because this hcall is never called.
>>
>> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
>> ---
>> arch/powerpc/platforms/pseries/setup.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
>> index c9fcc30a0365..654d2b999c25 100644
>> --- a/arch/powerpc/platforms/pseries/setup.c
>> +++ b/arch/powerpc/platforms/pseries/setup.c
>> @@ -803,7 +803,8 @@ static void __init pSeries_setup_arch(void)
>>
>> pseries_setup_security_mitigations();
>> #ifdef CONFIG_PPC_64S_HASH_MMU
>> - pseries_lpar_read_hblkrm_characteristics();
>> + if (!radix_enabled())
>> + pseries_lpar_read_hblkrm_characteristics();
>> #endif
>
> As far as I can see the function always exists so the #ifdef can be removed.
You're right, I'll do that in the v2
>>
>> /* By default, only probe PCI (can be overridden by rtas_pci) */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-23 16:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-20 15:57 [PATCH] powerpc/64s: Don't read H_BLOCK_REMOVE characteristics in radix mode Laurent Dufour
2022-05-20 16:15 ` Christophe Leroy
2022-05-23 16:09 ` Laurent Dufour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).