From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73432C433F5 for ; Wed, 1 Jun 2022 12:36:03 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LCpXd5LPtz3bvP for ; Wed, 1 Jun 2022 22:36:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.167.175; helo=mail-oi1-f175.google.com; envelope-from=robherring2@gmail.com; receiver=) Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LCpX630cVz2xvw for ; Wed, 1 Jun 2022 22:35:33 +1000 (AEST) Received: by mail-oi1-f175.google.com with SMTP id w130so2515473oig.0 for ; Wed, 01 Jun 2022 05:35:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=82L4X+R71tB/oBHFieTxctNvKfw4v3mlwwZIdAh9rvk=; b=BMZUAlKBiZaCIrxQOyhyrUPWLAY0MRr1/aKvljZDg2yG4f5xr62ae8X6qL6sypZtRw IOBUtdYZ7SWrUkVRcju0DJTKD4Rc6eJZY19007DVEz6B6WeewItzV3+IfeJEMXaqLvUE CJIgxgT/mgAr+0OdF87bdcTUPd+ThzWBsgKduMJT4IrQhkUH27UOvP41Ni29wMJ3Z42q As59Yx/PGI53ezrlbXHY6qBiiJY84apSwM7nZ9AprYxfPJvj4tHOUCosjAY8t1N8Uz4k /RzDxZ0hLDIks1AKri1fy/FcwB4Oa6GGb4wrKXinY2Vi7BtpSgB7pLjvNuJ63aCVFvkw 54jQ== X-Gm-Message-State: AOAM530KVZ+X8Zsi7uA8lf3nF4XTNMfgwMJmFGu/m3YAstVAgl9RlYTt DCM9/qmt76V4BGiTt2OdVQ== X-Google-Smtp-Source: ABdhPJzVwly1aZVPqXvvzde/yRFC+/eJWAmhpCecasnCwaemv3chTF+FUk0DafomWcC/mJWafCRfPg== X-Received: by 2002:a54:458c:0:b0:32a:f3f1:a6e7 with SMTP id z12-20020a54458c000000b0032af3f1a6e7mr14730295oib.179.1654086929964; Wed, 01 Jun 2022 05:35:29 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d22-20020a056830045600b00608b8e6fad5sm658392otc.76.2022.06.01.05.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 05:35:29 -0700 (PDT) Received: (nullmailer pid 3764642 invoked by uid 1000); Wed, 01 Jun 2022 12:35:29 -0000 Date: Wed, 1 Jun 2022 07:35:29 -0500 From: Rob Herring To: Christian Zigotzky Subject: Re: [FSL P50x0] Keyboard and mouse don't work anymore after the devicetree updates for 5.19 Message-ID: <20220601123529.GA3760306-robh@kernel.org> References: <87A6751F-9F21-4D06-A664-910F27459D5C@xenosoft.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87A6751F-9F21-4D06-A664-910F27459D5C@xenosoft.de> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Darren Stevens , mad skateman , Prabhakar Mahadev Lad , "R.T.Dickinson" , linuxppc-dev , Christian Zigotzky Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, May 31, 2022 at 06:29:38PM +0200, Christian Zigotzky wrote: > > > > On 31. May 2022, at 15:46, Rob Herring wrote: > > > > On Mon, May 30, 2022 at 12:26 AM Christian Zigotzky > > wrote: > >> > >>> On 27 May 2022 at 04:23 pm, Rob Herring wrote: > >>> The issue is in drivers/usb/host/fsl-mph-dr-of.c which copies the > >>> resources to a child platform device. Can you try the following > >>> change: > >>> > >>> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c > >>> index 44a7e58a26e3..47d9b7be60da 100644 > >>> --- a/drivers/usb/host/fsl-mph-dr-of.c > >>> +++ b/drivers/usb/host/fsl-mph-dr-of.c > >>> @@ -80,8 +80,6 @@ static struct platform_device *fsl_usb2_device_register( > >>> const char *name, int id) > >>> { > >>> struct platform_device *pdev; > >>> - const struct resource *res = ofdev->resource; > >>> - unsigned int num = ofdev->num_resources; > >>> int retval; > >>> > >>> pdev = platform_device_alloc(name, id); > >>> @@ -106,11 +104,7 @@ static struct platform_device *fsl_usb2_device_register( > >>> if (retval) > >>> goto error; > >>> > >>> - if (num) { > >>> - retval = platform_device_add_resources(pdev, res, num); > >>> - if (retval) > >>> - goto error; > >>> - } > >>> + pdev->dev.of_node = ofdev->dev.of_node; > >>> > >>> retval = platform_device_add(pdev); > >>> if (retval) > >> Hello Rob, > >> > >> Thanks a lot for your patch! Unfortunately, this leads to a boot loop. > >> Do you have another idea? > > > > Do you have a dmesg log? > > From the boot loop? Yes. > > > > > The other way to fix is creating a IRQ resource and adding it to the > > child device resources. > > Good idea. Not really. I'd rather have the child device just point to the DT node, but that doesn't seem to work for some drivers and I want to understand why. Rob