* [PATCH] ASoC: fsl: Check before clk_put() not needed
@ 2022-06-01 13:14 Yihao Han
2022-06-01 13:22 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Yihao Han @ 2022-06-01 13:14 UTC (permalink / raw)
To: Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, NXP Linux Team,
alsa-devel, linuxppc-dev, linux-arm-kernel, linux-kernel
Cc: Yihao Han
clk_put() already checks the clk ptr using !clk and IS_ERR()
so there is no need to check it again before calling it.
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
sound/soc/fsl/imx-sgtl5000.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
index 580a0d963f0e..16a281820186 100644
--- a/sound/soc/fsl/imx-sgtl5000.c
+++ b/sound/soc/fsl/imx-sgtl5000.c
@@ -185,8 +185,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
put_device:
put_device(&codec_dev->dev);
fail:
- if (data && !IS_ERR(data->codec_clk))
- clk_put(data->codec_clk);
+ clk_put(data->codec_clk);
of_node_put(ssi_np);
of_node_put(codec_np);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: fsl: Check before clk_put() not needed
2022-06-01 13:14 [PATCH] ASoC: fsl: Check before clk_put() not needed Yihao Han
@ 2022-06-01 13:22 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2022-06-01 13:22 UTC (permalink / raw)
To: Yihao Han
Cc: alsa-devel, linuxppc-dev, linux-kernel, Xiubo Li, Shengjiu Wang,
Takashi Iwai, Liam Girdwood, Jaroslav Kysela, Nicolin Chen,
Mark Brown, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
Fabio Estevam, linux-arm-kernel
On Wed, Jun 01, 2022 at 06:14:29AM -0700, Yihao Han wrote:
> clk_put() already checks the clk ptr using !clk and IS_ERR()
> so there is no need to check it again before calling it.
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
> sound/soc/fsl/imx-sgtl5000.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
> index 580a0d963f0e..16a281820186 100644
> --- a/sound/soc/fsl/imx-sgtl5000.c
> +++ b/sound/soc/fsl/imx-sgtl5000.c
> @@ -185,8 +185,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
> put_device:
> put_device(&codec_dev->dev);
> fail:
> - if (data && !IS_ERR(data->codec_clk))
> - clk_put(data->codec_clk);
> + clk_put(data->codec_clk);
The fail label is used before data is initialized, so the if (data)
check is really needed.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-01 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-01 13:14 [PATCH] ASoC: fsl: Check before clk_put() not needed Yihao Han
2022-06-01 13:22 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).