From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Michael Ellerman" <mpe@ellerman.id.au>
Cc: linux-mtd@lists.infradead.org, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, kernel@pengutronix.de
Subject: Re: [PATCH 03/14] mtd: powernv_flash: Warn about failure to unregister mtd device
Date: Thu, 9 Jun 2022 15:09:59 +0200 [thread overview]
Message-ID: <20220609130959.293421-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220603210758.148493-4-u.kleine-koenig@pengutronix.de>
On Fri, 2022-06-03 at 21:07:47 UTC, =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= wrote:
> mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow.
>
> This matches how other drivers (e.g. nand/raw/nandsim.c) use
> mtd_device_unregister().
>
> By returning 0 in the platform remove callback a generic error message
> by the device core is suppressed, nothing else changes.
>
> This is a preparation for making platform remove callbacks return void.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
next prev parent reply other threads:[~2022-06-09 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 21:07 [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Uwe Kleine-König
2022-06-03 21:07 ` [PATCH 03/14] mtd: powernv_flash: Warn about failure to unregister mtd device Uwe Kleine-König
2022-06-09 13:09 ` Miquel Raynal [this message]
2022-06-06 13:18 ` [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Miquel Raynal
2022-06-07 9:32 ` Pratyush Yadav
2022-06-07 10:47 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220609130959.293421-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=richard@nod.at \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).