From: "Erhard F." <erhard_f@mailbox.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, tzimmermann@suse.de
Subject: Re: [Bug 216095] New: sysfs: cannot create duplicate filename '/devices/platform/of-display'
Date: Wed, 15 Jun 2022 13:28:16 +0200 [thread overview]
Message-ID: <20220615132816.197c6657@yea> (raw)
In-Reply-To: <87zgifbazm.fsf@mpe.ellerman.id.au>
On Wed, 15 Jun 2022 00:01:01 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:
> Hi Erhard,
>
> This is presumably caused by:
>
> 52b1b46c39ae ("of: Create platform devices for OF framebuffers")
>
> Can you try the patch below?
>
> cheers
>
>
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 3507095a69f6..a70ff9df5cb9 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -556,7 +556,7 @@ static int __init of_platform_default_populate_init(void)
> if (!of_get_property(node, "linux,opened", NULL) ||
> !of_get_property(node, "linux,boot-display", NULL))
> continue;
> - dev = of_platform_device_create(node, "of-display", NULL);
> + dev = of_platform_device_create(node, NULL, NULL);
> if (WARN_ON(!dev))
> return -ENOMEM;
> boot_display = node;
> @@ -565,7 +565,7 @@ static int __init of_platform_default_populate_init(void)
> for_each_node_by_type(node, "display") {
> if (!of_get_property(node, "linux,opened", NULL) || node == boot_display)
> continue;
> - of_platform_device_create(node, "of-display", NULL);
> + of_platform_device_create(node, NULL, NULL);
> }
>
> } else {
>
Hi Michael!
Applied your patch on top of v5.19-rc2 and can confirm it works, thanks!
Also the "Using unsupported 1920x1080 (null) at a0008000, depth=8, pitch=2048" later on is gone in the dmesg.
Cheers
next prev parent reply other threads:[~2022-06-15 11:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 22:23 [Bug 216095] New: sysfs: cannot create duplicate filename '/devices/platform/of-display' bugzilla-daemon
2022-06-08 22:24 ` [Bug 216095] " bugzilla-daemon
2022-06-14 14:01 ` [Bug 216095] New: " Michael Ellerman
2022-06-15 11:28 ` Erhard F. [this message]
2022-08-15 23:29 ` [Bug 216095] " bugzilla-daemon
2022-08-15 23:30 ` bugzilla-daemon
2022-08-16 0:11 ` bugzilla-daemon
2022-11-14 23:52 ` bugzilla-daemon
2022-11-14 23:53 ` bugzilla-daemon
2022-12-31 15:22 ` bugzilla-daemon
2022-12-31 15:22 ` bugzilla-daemon
2023-01-02 6:10 ` bugzilla-daemon
2023-01-08 14:58 ` bugzilla-daemon
2023-01-08 15:01 ` bugzilla-daemon
2023-01-09 10:00 ` bugzilla-daemon
2023-01-14 13:11 ` bugzilla-daemon
2023-01-14 13:12 ` bugzilla-daemon
2023-01-17 17:07 ` bugzilla-daemon
2023-02-23 15:11 ` bugzilla-daemon
2023-04-12 0:33 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615132816.197c6657@yea \
--to=erhard_f@mailbox.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).