From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96BA1C433EF for ; Tue, 28 Jun 2022 00:29:41 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LX5835gGxz3cCV for ; Tue, 28 Jun 2022 10:29:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=axis.com header.i=@axis.com header.a=rsa-sha256 header.s=axis-central1 header.b=S/iODZvh; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=axis.com (client-ip=195.60.68.17; helo=smtp1.axis.com; envelope-from=jesper.nilsson@axis.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=axis.com header.i=@axis.com header.a=rsa-sha256 header.s=axis-central1 header.b=S/iODZvh; dkim-atps=neutral Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LWmDr1jZBz2xbY for ; Mon, 27 Jun 2022 21:47:38 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1656330461; x=1687866461; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=HvYHOeFy99wGwq/w2fx0FEcTo66gkhtePc7lFcpF/fs=; b=S/iODZvht98C4u69EXSfAaC4sMgtoPaKaoi+UA1oX1vqT1pQjHBJkJL6 DUn5H+vnRjzISY4c9fSw6MQmI1b0fpMlmPKzlSkV7n9iTsNqPPUbTCuEa DVeah8uq6hKHOi3jXRRTbC84h+e6vq0Sz5J5SUOsxSdRJQm0qnz+6MrNZ pfcDroaiRkjyaPQEa6UtJo0rjZHklOm+IbGpHx0hkN/WUd67Kd8dW5e9g qosoaIlLq87YyS61hF30K/4RSeOGzoLfxd0N6fv9Cp+a+1wtCmh4B2pqf LMM5noDpcBJY0tE2aD82R0hx2S/ngDJpzGe/g2iBoG83S5Vlcyl/1S630 A==; Date: Mon, 27 Jun 2022 13:47:33 +0200 From: Jesper Nilsson To: Serge Semin Subject: Re: [PATCH RESEND v5 15/18] PCI: dwc: Add dw_ prefix to the pcie_port structure name Message-ID: <20220627114733.GG13332@axis.com> References: <20220624143428.8334-1-Sergey.Semin@baikalelectronics.ru> <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220624143428.8334-16-Sergey.Semin@baikalelectronics.ru> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Tue, 28 Jun 2022 10:29:05 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Thomas Petazzoni , Kunihiko Hayashi , Neil Armstrong , "linux-pci@vger.kernel.org" , Lorenzo Pieralisi , Binghui Wang , Frank Li , Bjorn Andersson , Minghuan Lian , Thierry Reding , Pavel Parkhomenko , Alim Akhtar , Jonathan Chocron , Nobuhiro Iwamatsu , Jonathan Hunter , Fabio Estevam , Jerome Brunet , Rob Herring , Jesper Nilsson , Lorenzo Pieralisi , Kevin Hilman , Pratyush Anand , "linux-tegra@vger.kernel.org" , linux-arm-kernel , Kishon Vijay Abraham I , "linux-rockchip@lists.infradead.org" , Rahul Tanwar , Andy Gross , NXP Linux Team , Xiaowei Song , Greentime Hu , Richard Zhu , "linux-omap@vger.kernel.org" , Srikanth Thokala , Martin Blumenstingl , "linux-arm-msm@vger.kernel.org" , Sascha Hauer , Manivannan Sadhasivam , Yue Wang , "linux-samsung-soc@vger.kernel.org" , Paul Walmsley , Bjorn Helgaas , "linux-amlogic@lists.infradead.org" , Alexey Malahov , Mingkai Hu , "linux-arm-kernel@lists.infradead.org" , Roy Zang , Jingoo Han , "linuxppc-dev@lists.ozlabs.org" , Heiko Stuebner , "linux-kernel@vger.kernel.org" , Serge Semin , Stanimir Varbanov , Krzysztof Kozlowski , Masami Hiramatsu , Pengutronix Kernel Team , Gustavo Pimentel , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jun 24, 2022 at 04:34:25PM +0200, Serge Semin wrote: > All of the DW PCIe core driver entities have names with the dw_ prefix in > order to easily distinguish local and common PCIe name spaces. All except > the pcie_port structure which contains the DW PCIe Root Port descriptor. > For historical reason the structure has retained the original name since > commit 340cba6092c2 ("pci: Add PCIe driver for Samsung Exynos") when > the DW PCIe IP-core support was added to the kernel. Let's finally fix > that by adding the dw_ prefix to the structure name and by adding the _rp > suffix to be similar to the EP counterpart. Thus the name will be coherent > with the common driver naming policy. It shall make the driver code more > readable eliminating visual confusion between the local and generic PCI > name spaces. > > Signed-off-by: Serge Semin > Reviewed-by: Rob Herring Sorry, I never replied in the thread for the last patch, your reasoning for not changing the parameter name made sense. For the ARTPEC-6 parts, Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com