From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2FD6C433EF for ; Wed, 29 Jun 2022 10:25:19 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LXyJt22sCz3f9S for ; Wed, 29 Jun 2022 20:25:18 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=KDGJ+ZX0; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=kabel@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=KDGJ+ZX0; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LXwvg5XW4z3cFp for ; Wed, 29 Jun 2022 19:21:51 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA2E161E2A; Wed, 29 Jun 2022 09:21:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A6A5C34114; Wed, 29 Jun 2022 09:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656494506; bh=HQ25Ow2lpsqgoUrUW/nG+URV4v3uVvi69tP+dqJVwS8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KDGJ+ZX0QDwKOanqLEHq4R3Rgk4gw7YBpXQ1tp5J2PbFlN9SFFfxpykmheKoDEBKH GZdb6/Vu19P209bnRNGK3ZFDu4CTBf7M/1tGbAgk0qvALDE6m6bUxa1i55igZp5mYn M9nKXnXHahfEJ1/gD9uIZsD8u8SACyrjQAA5RstBhscMb/v3jVsSe8amKh8qkDuMrS GSpJXwgYiOg6nUIYiiXl948rxcrWW3Rc1By0vwkqaGsbNa0kxgo7uX8LQpEE5EFJvC lXPBmC+HFU37tkvSye7TN5YXt1OC7tohvK8VYqANalwO76xOIXwCRjtMw86pXFhld/ h03Us4Elobz6g== Date: Wed, 29 Jun 2022 11:20:42 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220629112042.221af80b@thinkpad> In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Wed, 29 Jun 2022 20:19:09 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Ricardo Ribalda , Jimmy Su , Linus Walleij , Sekhar Nori , Gwendal Grignou , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Benjamin Tissoires , Paul Mackerras , Moses Christopher Bollavarapu , Pavel Machek , Miquel Raynal , Heikki Krogerus , Evgeniy Polyakov , Matt Johnston , Olli Salonen , Angela Czubak , Robert Marko , Luka Perkov , Sean Young , Dave Stevenson , Zheyu Ma , Javier Martinez Canillas , Chanwoo Choi , linux-omap@vger.kernel.org, An tti Palosaari , Wenyou Yang , Dongchun Zhu , Miaoqian Lin , Steve Longerbeam , Bingbu Cao , Shunqian Zheng , lijian , Dan Carpenter , Bartlomiej Zolnierkiewicz , Viorel Suman , Petr Machata , Guido =?UTF-8?B?R8O8bnRoZXI=?= , Jean Delvare , linux-serial@vger.kernel.org, linux-pm@vger.kernel.org, Eddie James , Riku Voipio , James Schulman , Scott Wood , Cai Huoqing , Jonas Malaco , Hsin-Yi Wang , Haibo Chen , Petr Cvek , linux-leds@vger.kernel.org, Joe Tessler , Andrey Konovalov < andreyknvl@gmail.com>, Andy Shevchenko , Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , Heungjun Kim , Hans Verkuil , David Lin , Vladimir Oltean , David Rhodes , Claudiu Beznea , Jean-Baptiste Maneyrol , Alexandre Belloni , Dan Robertson , Martyn Welch , Jiri Slaby , devicetree@vger.kernel.org, David Airlie , Jon Nettleton , Srinivas Pandruvada , Marco Felsch , Wim Van Sebroeck , Sebastian Reichel , Max Filippov , "Lad, Prabhakar" , Thierry Reding , linux-i2c@vger.kernel.org, Martiros Shakhzadyan , Guenter Roeck , Matthias Schwarzott , Sylwester Nawrocki , Eric Dumazet , Leon Luo , Saranya Gopal , Lars-Peter Clausen , Corey Minyard , Evgeny Novikov , Frank Rowand , Bartosz Golaszewski , Manivannan Sadhasivam , Pierre-Louis Bossart , Minghao Chi < chi.minghao@zte.com.cn>, linux-clk@vger.kernel.org, Nathan Chancellor , MyungJoo Ham , Charles Gorand , Jagan Teki , Vijendar Mukunda , Miguel Ojeda , Kyungmin Park , Tianshu Qiu , Martin Donnelly , Woojung Huh , Rudolf Marek , Charles Keepax , linux-watchdog@vger.kernel.org, Michael Hennerich , Ido Schimmel , acpi4asus-user@lists.sourceforge.net, Simon Trimmer , Ricard Wanderlof , Rikard Falkeborn , Alex Deucher , Jiri Valek - 2N , linux-rpi-kernel@lists.infradead.org, Biju Das , Wayne Chang , Chen-Yu Tsai , Sing-Han Chen , linux-arm-kernel@lists.infradead.org, Niklas =?UTF-8?B?U8O2ZGVybHVuZA==?= , Hans de Goede , Stephen Boyd , Maslov Dmitry , linux-gpio@vger.kernel.org, Jens Frederich , Douglas Anderson , "David S. Miller" , Wolfram Sang , Jarkko Sakkinen , linux-usb@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , CGEL ZTE , Colin Leroy , platform-driver-x86@vger.kernel.org, linux-integrity@vger.kernel.org, Kevin Tsai , Pali =?UTF-8?B?Um9ow6Fy?= , Jonathan Cameron , Heiner Kallweit , Daniel Palmer , Arec Kao , Crt Mori , Jose Cazarin , Neil Armstrong , linux-iio@vger.kernel.org, Tom Rix , Michael Turquette , Peter Senna Tschudin , Benjamin Mugnier , Nuno =?UTF-8?B?U8Oh?= , Jan-Simon Moeller , Wei Yongjun , Laurent Pinchart , Andrzej Hajda , Nikita Travkin , Jeremy Kerr , Jasmin Jessich , Sam Ravnborg , Kevin Cernekee , Alyssa Rosenzweig , linux-rtc@vger.kernel.org, Daniel Thompson , Florian Fainelli , Lucas Tanure , Stefan Mavrodiev , Masahiro Yamada , Sylvain Petinot , netdev@vger.kernel.org, Kieran Bingham , Jernej Skrabec , Xin Ji , Seven Lee , Matt Ranostay , Broadcom internal kernel review list , Adrien Grassein , Yang Yingliang , chrome-platform@lists.linux.dev, Mats Randgaard , Paolo Abeni , Alexey Dobriyan , Joel Stanley , linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Lyude Paul , Kees Cook , Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Jonas Karlman , Yang Li , Tim Harvey , Jiri Kosina , Akinobu Mita , Mark Gross , Richard Fitzgerald , Mark Brown < broonie@kernel.org>, wengjianfeng , Maxime Ripard , Sven Peter , Martin Kepplinger , openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab , Benson Leung , "Daniel W. S. Almeida" , Chiranjeevi Rapolu , Alessandro Zummo , linux-hwmon@vger.kernel.org, Felipe Balbi , Stephan Gerhold , Support Opensource , Alexandru Ardelean , Dmitry Torokhov , Marc Hulsman , Corentin Chary , Stephen Kitt , Daniel Scally , linux-fbdev@vger.kernel.org, Andrey Ryabinin , Arnd Bergmann , Kirill Shilimanov , Sakari Ailus , patches@opensource.cirrus.com, Zh eng Yongjun , Alejandro Tafalla , Peter Rosin , Arnaud Ferraris , Hector Martin , Vignesh Raghavendra , Nick Dyer , Greg Kroah-Hartman , Tony Lindgren , Alexandre Torgue , Takashi Iwai , Paul Cercueil , George McCollister , Mac Chiang , Antoniu Miclaus , Alexander Potapenko , linux-staging@lists.linux.dev, Adam Ford , Peter Huewe , UNGLinuxDriver@microchip.com, Lee Jones , linux-mtd@lists.infradead.org, Alexey Khoroshilov , Marek Vasut , Paul Kocialkowski , alsa-devel@alsa-project.org, Vincenzo Frasc ino , Eric Piel , Herbert Xu , Tobias Schrammm , Richard Weinberger , Tomasz Duszynski , Janusz Krzysztofik , Russell King , linux-pwm@vger.kernel.org, Jason Gunthorpe , Thomas Zimmermann , Bastien Nocera , Jingoo Han , Jakub Kicinski , Vivien Didelot , Yizhuo , Shawn Tu , linux-media@vger.kernel.org, Yan Lei , Akihiro Tsukada , Tudor Ambarus , Dmitry Rokosov , Oliver Graute , Alistair Francis , Dongliang Mu , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Eduardo Valentin , Rui Migue l Silva , Michael Srba , Rob Herring , linux-mediatek@lists.infradead.org, Fabio Estevam , Matthias Brugger , kasan-dev@googlegroups.com, "Paul J. Murphy" , Nicola Lunghi , Daniele Alessandrelli , Dmitry Vyukov , Ramesh Shanmugasundaram , Liam Girdwood , Juerg Haefliger , Oder Chiou , Shengjiu Wang , Nicolas Ferre , Robert Foss , Krzysztof Kozlowski , Daniel Vetter , Alvin =?UTF-8?B?xaBpcHJhZ2E=?= , Luca Ceresoli , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , Johannes Berg , Colin Ian King , Maximilian Luz , Helge Deller , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 28 Jun 2022 16:03:12 +0200 Uwe Kleine-K=C3=B6nig wrote: > From: Uwe Kleine-K=C3=B6nig >=20 > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig For > drivers/leds/leds-turris-omnia.c | 4 +--- Acked-by: Marek Beh=C3=BAn