From: "Pali Rohár" <pali@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Michael Ellerman <michael@ellerman.id.au>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] powerpc: e500: Fix compilation with gcc e500 compiler
Date: Sun, 10 Jul 2022 19:57:27 +0200 [thread overview]
Message-ID: <20220710175727.ee52xoqfwlphjxv5@pali> (raw)
In-Reply-To: <c77df184-c79c-8d81-0327-9eaefb71c890@csgroup.eu>
On Sunday 10 July 2022 17:38:33 Christophe Leroy wrote:
> Le 09/07/2022 à 12:23, Pali Rohár a écrit :
> >>>
> >>> -ifdef CONFIG_PPC_BOOK3S_64
> >>> ifdef CONFIG_CPU_LITTLE_ENDIAN
> >>> -CFLAGS-$(CONFIG_GENERIC_CPU) += -mcpu=power8
> >>> -CFLAGS-$(CONFIG_GENERIC_CPU) += $(call cc-option,-mtune=power9,-mtune=power8)
> >>> +CFLAGS-$(CONFIG_PPC_BOOK3S_64) += -mcpu=power8
> >>> +CFLAGS-$(CONFIG_PPC_BOOK3S_64) += $(call cc-option,-mtune=power9,-mtune=power8)
> >>> else
> >>> -CFLAGS-$(CONFIG_GENERIC_CPU) += $(call cc-option,-mtune=power7,$(call cc-option,-mtune=power5))
> >>> -CFLAGS-$(CONFIG_GENERIC_CPU) += $(call cc-option,-mcpu=power5,-mcpu=power4)
> >>> -endif
> >>> -else ifdef CONFIG_PPC_BOOK3E_64
> >>> -CFLAGS-$(CONFIG_GENERIC_CPU) += -mcpu=powerpc64
> >>> +CFLAGS-$(CONFIG_PPC_BOOK3S_64) += $(call cc-option,-mtune=power7,$(call cc-option,-mtune=power5))
> >>> +CFLAGS-$(CONFIG_PPC_BOOK3S_64) += $(call cc-option,-mcpu=power5,-mcpu=power4)
> >>
> >> So before that change I got -mcpu=power9
> >>
> >> Now I get -mtune=power7 -mcpu=power5 -mcpu=power9
> >
> > I did it like Arnd wrote.
> >
> > And seems that it does not work and now is fully out of the scope of the
> > original issue. Now I'm really lost here.
> >
> > So I nobody comes with better solution, I would prefer to stick with my
> > original version which targets _only_ e500 cores.
> >
> > Any other suggestion?
>
> I sent a patch based on the TARGET_CPU logic, does it work for you ?
>
> Christophe
Perfect, it works! Thank you.
Anyway, same problem is with arch/powerpc/boot/Makefile file when
building "uImage" target. There is hardcoded -mcpu=powerpc flag.
next prev parent reply other threads:[~2022-07-10 17:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 9:39 [PATCH] powerpc: e500: Fix compilation with gcc e500 compiler Pali Rohár
2022-05-24 17:59 ` Segher Boessenkool
2022-05-24 18:12 ` Pali Rohár
2022-05-24 18:52 ` Segher Boessenkool
2022-05-24 19:16 ` Pali Rohár
2022-05-24 19:52 ` Segher Boessenkool
2022-07-02 9:39 ` Pali Rohár
2022-07-02 9:44 ` Pali Rohár
2022-07-04 10:23 ` Michael Ellerman
2022-07-04 10:39 ` Pali Rohár
2022-07-04 12:07 ` Arnd Bergmann
2022-07-04 13:13 ` Pali Rohár
2022-07-04 13:22 ` Arnd Bergmann
2022-07-04 13:29 ` Pali Rohár
2022-07-04 13:43 ` Arnd Bergmann
2022-07-07 9:56 ` Christophe Leroy
2022-07-07 9:59 ` Pali Rohár
2022-07-08 17:14 ` Pali Rohár
2022-07-08 20:06 ` Arnd Bergmann
2022-07-09 9:16 ` Christophe Leroy
2022-07-09 10:23 ` Pali Rohár
2022-07-10 17:38 ` Christophe Leroy
2022-07-10 17:57 ` Pali Rohár [this message]
2022-07-11 14:20 ` Christophe Leroy
2022-07-08 17:12 ` Pali Rohár
2022-07-08 20:04 ` Arnd Bergmann
2022-07-09 8:51 ` Christophe Leroy
2022-07-09 9:26 ` Christophe Leroy
2022-07-11 16:14 ` Segher Boessenkool
2022-07-11 17:32 ` Christophe Leroy
2022-07-11 21:48 ` Segher Boessenkool
2022-07-12 9:22 ` Christophe Leroy
2022-07-12 14:11 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220710175727.ee52xoqfwlphjxv5@pali \
--to=pali@kernel.org \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox