From: Scott Cheloha <cheloha@linux.ibm.com>
To: linux-watchdog@vger.kernel.org
Cc: nathanl@linux.ibm.com, wvoigt@us.ibm.com, aik@ozlabs.ru,
vaishnavi@linux.ibm.com, npiggin@gmail.com, tzungbi@kernel.org,
brking@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux@roeck-us.net
Subject: [PATCH v3 0/4] pseries-wdt: initial support for H_WATCHDOG-based watchdog timers
Date: Wed, 13 Jul 2022 15:23:31 -0500 [thread overview]
Message-ID: <20220713202335.1217647-1-cheloha@linux.ibm.com> (raw)
PAPR v2.12 defines a new hypercall, H_WATCHDOG. This patch series
adds support for this hypercall to powerpc/pseries kernels and
introduces a new watchdog driver, "pseries-wdt", for the virtual
timers exposed by the hypercall.
This series is preceded by the following:
RFC v1: https://lore.kernel.org/linux-watchdog/20220413165104.179144-1-cheloha@linux.ibm.com/
RFC v2: https://lore.kernel.org/linux-watchdog/20220509174357.5448-1-cheloha@linux.ibm.com/
PATCH v1: https://lore.kernel.org/linux-watchdog/20220520183552.33426-1-cheloha@linux.ibm.com/
PATCH v2: https://lore.kernel.org/linux-watchdog/20220602175353.68942-1-cheloha@linux.ibm.com/
Changes of note from PATCH v2:
- Don't keep a pointer to the platform device at registration
time. We don't use the pointer for anything and we cannot
hotplug the "device".
- Drop the GETFIELD() and SETFIELD() macros: Michael Ellerman really
doesn't like them. Use plain integer constants and custom bitfield
extraction macros for the capability output instead.
(After making the change I can see the upside to plain constants.)
- Actually use PSERIES_WDTQ_MAX_NUMBER(): check that the hypervisor
gave us at least one timer to work with.
- Use MSEC_PER_SEC in a few places instead of the literal 1000 to
show the reader what we're doing.
- Use "reverse xmas tree" sorting for automatic variable declarations.
- Note where the max_timeout of (UINT_MAX / 1000) comes from.
- Nix email addresses from the MODULE_AUTHOR() macros, they tend to
rot.
next reply other threads:[~2022-07-13 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 20:23 Scott Cheloha [this message]
2022-07-13 20:23 ` [PATCH v3 1/4] powerpc/pseries: hvcall.h: add H_WATCHDOG opcode, H_NOOP return code Scott Cheloha
2022-07-13 20:23 ` [PATCH v3 2/4] powerpc/pseries: add FW_FEATURE_WATCHDOG flag Scott Cheloha
2022-07-13 20:23 ` [PATCH v3 3/4] powerpc/pseries: register pseries-wdt device with platform bus Scott Cheloha
2022-07-13 20:23 ` [PATCH v3 4/4] watchdog/pseries-wdt: initial support for H_WATCHDOG-based watchdog timers Scott Cheloha
2022-07-13 20:50 ` Guenter Roeck
2022-07-25 16:11 ` Scott Cheloha
2022-07-25 21:30 ` Guenter Roeck
2022-07-26 7:14 ` Michael Ellerman
2022-07-29 13:01 ` [PATCH v3 0/4] pseries-wdt: " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713202335.1217647-1-cheloha@linux.ibm.com \
--to=cheloha@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=brking@linux.ibm.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathanl@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=tzungbi@kernel.org \
--cc=vaishnavi@linux.ibm.com \
--cc=wvoigt@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).