From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59EF6C43334 for ; Sun, 17 Jul 2022 23:36:32 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LmM1W0B5Qz3chQ for ; Mon, 18 Jul 2022 09:36:31 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ucw.cz header.i=@ucw.cz header.a=rsa-sha256 header.s=gen1 header.b=DbT/eKOB; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=ucw.cz (client-ip=46.255.230.98; helo=jabberwock.ucw.cz; envelope-from=pavel@ucw.cz; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=ucw.cz header.i=@ucw.cz header.a=rsa-sha256 header.s=gen1 header.b=DbT/eKOB; dkim-atps=neutral X-Greylist: delayed 726 seconds by postgrey-1.36 at boromir; Sun, 17 Jul 2022 22:48:07 AEST Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Lm4dM3dfCz305c for ; Sun, 17 Jul 2022 22:48:07 +1000 (AEST) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7F4CB1C0003; Sun, 17 Jul 2022 14:35:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1658061351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cBf+jWRDoNQnkPa+e9dAEb6sr2FGwNq/30S0BQ1Xqz8=; b=DbT/eKOBSicA8m6NsmFdT+RnbQvM2Vn99CqENLl4IcBCtH2dDHjIVUoScSV5U33J8BSYOy /vD6BG0WFMtMbK1J5xWQKlxFBPY+q7JqkbZRUIIe9ihV1tKT1I3OgzyeWyb3jetv7WZOoT wereL1OJD8bn2nEednAgBymraZ5gEhE= Date: Sun, 17 Jul 2022 14:35:51 +0200 From: Pavel Machek To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220717123551.GJ14285@duo.ucw.cz> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="T4IYkFBVPN84tP7K" Content-Disposition: inline In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Mon, 18 Jul 2022 09:35:23 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Ricardo Ribalda , Jimmy Su , Linus Walleij , Sekhar Nori , Gwendal Grignou , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Benjamin Tissoires , Paul Mackerras , Moses Christopher Bollavarapu , Sylwester Nawrocki , Miquel Raynal , Heikki Krogerus , Evgeniy Polyakov , Matt Johnston , Olli Salonen , Angela Czubak , Robert Marko , Luka Perkov , Sean Young , Dave Stevenson , Zheyu Ma , Javier Martinez Canillas , Chanwoo Choi , linux-omap@vge r.kernel.org, Antti Palosaari , Wenyou Yang , Dongchun Zhu , Miaoqian Lin , Steve Longerbeam , Bingbu Cao , Shunqian Zheng , lijian , Dan Carpenter , Bartlomiej Zolnierkiewicz , Viorel Suman , Petr Machata , Guido =?iso-8859-1?Q?G=FCnther?= , Jean Delvare , linux-serial@vger.kernel.org, linux-pm@vger.kernel.org, Eddie James , Riku Voipio , James Schulman , Scott Wood , Cai Huoqing , Jonas Malaco , Hsin-Yi Wang , Haibo Chen , Petr Cvek , linux-leds@vger.kernel.org, Joe Tessler , Andrey Konovalov , Andy Shevche nko , Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , Heungjun Kim , Hans Verkuil , David Lin , Vladimir Oltean , David Rhodes , Claudiu Beznea , Jean-Baptiste Maneyrol , Alexandre Belloni , Dan Robertson , Martyn Welch , Jiri Slaby , devicetree@vger.kernel.org, David Airlie , Jon Nettleton , Srinivas Pandruvada , Marco Felsch , Wim Van Sebroeck , Sebastian Reichel , Max Filippov , "Lad, Prabhakar" , Thierry Reding , linux-i2c@vger.kernel.org, Martiros Shakhzadyan , Guenter Roeck , Matthias Schwarzott , Eric Dumazet , Marek =?iso-8859-1?Q?Beh=FAn?= , Saranya Gopal , Lars-Peter Clausen , Corey Minyard , Evgeny Novikov , Frank Rowand , Bartosz Golaszewski , Manivannan Sadhasivam , Pierre-Louis Bossart , Minghao Chi , linux-clk@vger.kernel.org, Nathan Chancellor , MyungJoo Ham , Charles Gorand , Jagan Teki , Vijendar Mukunda , Miguel Ojeda , Kyungmin Park , Tianshu Qiu , Martin Donnelly , Woojung Huh , Rudolf Marek , Charles Keepax , linux-watchdog@vger.kernel.org, Michael Hennerich , Ido Schimmel , acpi4asus-user@lists.sourceforge.net, Simon Trimmer , Ricard Wanderlof , Rikard Falkeborn , Alex Deucher , Jiri Valek - 2N , linux-rpi-kernel@lists.infradead.org, Biju Das , Wayne Chang , Chen-Yu Tsai , Sing-Han Chen , linux-arm-kernel@lists.infradead.org, Niklas =?iso-8859-1?Q?S=F6derlund?= , Hans de Goede , Stephen Boyd , Maslov Dmitry , linux-gpio@vger.kernel.org, Jens Frederich , Douglas Anderson , linux-media@vger.kernel.org, "David S. Miller" , Wolfram Sang , Jarkko Sakkinen , linux-usb@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , CGEL ZTE , Colin Leroy , platform-driver-x86@vger.kernel.org, linux-integrity@vger.kernel.org, Kevin Tsai , Pali =?iso-8859-1?Q?Roh=E1r?= , Jonathan Cameron , Heiner Kallweit , Daniel Palmer , Arec Kao , Crt Mori , Jose Caz arin , Neil Armstrong , linux-iio@vger.kernel.org, Tom Rix , Michael Turquette , Peter Senna Tschudin , Benjamin Mugnier , Nuno =?iso-8859-1?Q?S=E1?= , Jan-Simon Moeller , Wei Yongjun , Laurent Pinchart , Andrzej Hajda , Nikita Travkin , Jeremy Kerr , Jasmin Jessich , Sam Ravnborg , Kevin Cernekee , Alyssa Rosenzweig , linux-rtc@vger.kernel.org, Daniel Thompson , Florian Fainelli , Lucas Tanure , Stefan Mavrodiev , Masahiro Yamada , Sylvain Petinot , netdev@vger.kernel.org, Kieran Bingham , Jernej Skrabec , Xin Ji , Seven Lee , Matt Ranostay , Broadcom internal kernel review list , Adrien Grassein , Yang Yingliang , chrome-platform@lists.linux.dev, Mats Randgaard , Paolo Abeni , Alexey Dobriyan , Joel Stanley , linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Lyude Paul , Kees Cook , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jonas Karlman , Yang Li , Tim Harvey , Jiri Kosina , Akinobu Mita , Mark Gross , Richard Fitzgerald , Mark Brown , wengjian feng , Maxime Ripard , Sven Peter , Martin Kepplinger , openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab , Benson Leung , "Daniel W. S. Almeida" , Chiranjeevi Rapolu , Alessandro Zummo , linux-hwmon@vger.kernel.org, Felipe Balbi , Stephan Gerhold , Support Opensource , Alexandru Ardelean , Dmitry Torokhov , Marc Hulsman , Corentin Chary , Stephen Kitt , Daniel Scally , linux-fbdev@vger.kernel.org, Andrey Ryabinin , Arnd Bergmann , Kirill Shilimanov , Sakari Ailus , patches@o pensource.cirrus.com, Zheng Yongjun , Alejandro Tafalla , Peter Rosin , Arnaud Ferraris , Hector Martin , Vignesh Raghavendra , Nick Dyer , Greg Kroah-Hartman , Tony Lindgren , Alexandre Torgue , Takashi Iwai , Paul Cercueil , George McCollister , Mac Chiang , Antoniu Miclaus , Alexander Potapenko , linux-staging@lists.linux.dev, Adam Ford , Peter Huewe , UNGLinuxDriver@microchip.com, Lee Jones , linux-mtd@lists.infradead.org, Alexey Khoroshilov , Marek Vasut , Paul Kocialkowski , alsa-devel@alsa-pro ject.org, Vincenzo Frascino , Eric Piel , Herbert Xu , Tobias Schrammm , Richard Weinberger , Tomasz Duszynski , Janusz Krzysztofik , Russell King , linux-pwm@vger.kernel.org, Jason Gunthorpe , Thomas Zimmermann , Bastien Nocera , Jingoo Han , Jakub Kicinski , Vivien Didelot , Yizhuo , Shawn Tu , Leon Luo , Yan Lei , Akihiro Tsukada , Tudor Ambarus , Dmitry Rokosov , Oliver Graute , Alistair Francis , Dongliang Mu , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Eduardo Valentin , Rui Miguel Silva , Michael Srba , Rob Herring , linux-mediatek@lists.infradead.org, Fabio Estevam , Matthias Brugger , kasan-dev@googlegroups.com, "Paul J. Murphy" , Nicola Lunghi , Daniele Alessandrelli , Dmitry Vyukov , Ramesh Shanmugasundaram , Liam Girdwood , Juerg Haefliger , Oder Chiou , Shengjiu Wang , Nicolas Ferre , Robert Foss , Krzysztof Kozlowski , Daniel Vetter , Alvin =?utf-8?Q?=C5=A0ipraga?= , Luca Ceresoli , =?iso-8859-1?Q?Jos=E9_Exp=F3sito?= , Johannes Berg , Colin Ian King , Maximilian Luz , Helge Deller , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --T4IYkFBVPN84tP7K Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Uwe Kleine-K=F6nig >=20 > The value returned by an i2c driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. >=20 > Signed-off-by: Uwe Kleine-K=F6nig 2-4: Acked-by: Pavel Machek Best regards, Pavel --=20 People of Russia, stop Putin before his war on Ukraine escalates. --T4IYkFBVPN84tP7K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYtQCJwAKCRAw5/Bqldv6 8uLoAKCbwzuCGlS9LKQcrBTMJXgap3//dQCfasApR6kyXVLFz8BcHxrPzA1L43I= =dhr2 -----END PGP SIGNATURE----- --T4IYkFBVPN84tP7K--