From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62389C43334 for ; Wed, 20 Jul 2022 21:09:45 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Lp7cm0xnCz3d9Q for ; Thu, 21 Jul 2022 07:09:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4Lp7cK4jjTz2xk4 for ; Thu, 21 Jul 2022 07:09:21 +1000 (AEST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 26KL7IvI012552; Wed, 20 Jul 2022 16:07:18 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 26KL7I6U012551; Wed, 20 Jul 2022 16:07:18 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 20 Jul 2022 16:07:17 -0500 From: Segher Boessenkool To: Nicholas Piggin Subject: Re: [PATCH v3 1/2] powerpc: add ISA v3.0 / v3.1 wait opcode macro Message-ID: <20220720210717.GH25951@gate.crashing.org> References: <20220720132132.903462-1-npiggin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220720132132.903462-1-npiggin@gmail.com> User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Jul 20, 2022 at 11:21:31PM +1000, Nicholas Piggin wrote: > The wait instruction encoding changed between ISA v2.07 and ISA v3.0. > In v3.1 the instruction gained a new field. > > Update the PPC_WAIT macro to the current encoding. Rename the older > incompatible one with a _v203 suffix as it was introduced in v2.03 > (the WC field was introduced in v2.07 but the kernel only uses WC=0). Ah, it wasn't just embedded in 2.03, I see. Looks good to me, thanks! Reviewed-by: Segher Boessenkool Segher