From: Segher Boessenkool <segher@kernel.crashing.org>
To: Timothy Pearson <tpearson@raptorengineering.com>
Cc: "Dan Horák" <dan@danny.cz>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
amd-gfx <amd-gfx@lists.freedesktop.org>,
"Alex Deucher" <alexdeucher@gmail.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux@roeck-us.net
Subject: Re: [PATCH] drm/amdgpu: Re-enable DCN for 64-bit powerpc
Date: Mon, 25 Jul 2022 15:42:17 -0500 [thread overview]
Message-ID: <20220725204217.GU25951@gate.crashing.org> (raw)
In-Reply-To: <1446417444.13111032.1658777648586.JavaMail.zimbra@raptorengineeringinc.com>
On Mon, Jul 25, 2022 at 02:34:08PM -0500, Timothy Pearson wrote:
> >> Further digging shows that the build failures only occur with compilers
> >> that default to 64-bit long double.
> >
> > Where the heck do we have 'long double' things anywhere in the kernel?
> >
> > I tried to grep for it, and failed miserably. I found some constants
> > that would qualify, but they were in the v4l colorspaces-details.rst
> > doc file.
> >
> > Strange.
>
> We don't, at least not that I can see. The affected code uses standard doubles.
>
> What I'm wondering is if the compiler is getting confused between standard and long doubles when they are both the same bit length...
The compiler emits the same code (DFmode things, double precision float)
in both cases, and it itself does not see any difference anymore fairly
early in the pipeline. Compare to int and long on most 32-bit targets,
both are SImode, the compiler will not see different types anymore:
there *are* no types, except in the compiler frontend.
It only happens for powerpc64le things, and not for powerpc64 builds.
It is probably a GCC problem. I don't see what forces the GCC build
here to use 64-bit long double either btw? Compilers build via buildall
have all kinds of unnecessary things disabled, but not that, not
directly at least.
Segher
next prev parent reply other threads:[~2022-07-25 20:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 12:39 [PATCH] drm/amdgpu: Re-enable DCN for 64-bit powerpc Michael Ellerman
2022-07-25 15:45 ` Dan Horák
2022-07-25 18:12 ` Deucher, Alexander
2022-07-25 19:19 ` Linus Torvalds
2022-07-25 19:34 ` Timothy Pearson
2022-07-25 20:42 ` Segher Boessenkool [this message]
2022-07-25 22:40 ` Guenter Roeck
2022-07-26 0:31 ` Segher Boessenkool
2022-07-26 0:47 ` Michael Ellerman
2022-07-26 0:56 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725204217.GU25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dan@danny.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=torvalds@linux-foundation.org \
--cc=tpearson@raptorengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).